Install VSCode extensions at image build time instead of container init#350
Merged
Conversation
Moves Gemini Code Assist and Claude Code extension installation from a cont-init script (99-install-extensions) into the Dockerfile RUN step. This eliminates the s6-setuidgid dependency which fails in Workbench's restricted Kubernetes environment due to missing CAP_SETGID. Made-with: Cursor
pantherman594
approved these changes
Mar 30, 2026
Comment on lines
+19
to
+21
|
|
||
| USER root | ||
| RUN rm /tmp/geminicodeassist.vsix /tmp/claudecode.vsix |
Contributor
There was a problem hiding this comment.
nit: if we do the curling as abc we can also remove all in one RUN block. not highly important but it'll slightly reduce the amount of layers generated
michaelxiao7
force-pushed
the
vscode-extensions-df
branch
from
4db7a9a to
1d9a0ca
Compare
michaelxiao7
force-pushed
the
vscode-extensions-df
branch
from
1d9a0ca to
cec88e7
Compare
pantherman594
approved these changes
Mar 30, 2026
PeterSu92
pushed a commit
that referenced
this pull request
May 21, 2026
…it (#350) Install VSCode extensions at image build time instead of container init Moves Gemini Code Assist and Claude Code extension installation from a cont-init script (99-install-extensions) into the Dockerfile RUN step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Gemini Code Assist and Claude Code extension installation into the Dockerfile
Also added an empty line at the end of install.sh because I noticed that I removed it from my previous PR
PHP-135615