Add secret producer/receiver and docker credential helper#381
Merged
Conversation
pantherman594
force-pushed
the
consume-secret
branch
6 times, most recently
from
04fa6a5 to
82a8e91
Compare
Merged
pantherman594
force-pushed
the
consume-secret
branch
from
82a8e91 to
565aef7
Compare
pantherman594
force-pushed
the
consume-secret
branch
from
565aef7 to
ee3517d
Compare
pantherman594
force-pushed
the
consume-secret
branch
from
ee3517d to
85bc76b
Compare
june-hua
reviewed
Apr 29, 2026
june-hua
reviewed
Apr 30, 2026
june-hua
approved these changes
Apr 30, 2026
…multiple destinations for one secret name
PeterSu92
pushed a commit
that referenced
this pull request
May 21, 2026
See linked verily1 PR for ordering of when the scripts will be called. - `docker-auth-secrets.sh` registers docker-credential-workbench-secret to be used when pulling a package from one of the "dockerRepository" secrets. This must be called after git-clone-devcontainer since it needs to read the secret from the devcontainer directory - `docker-credential-secrets.sh` is the script behind docker-credential-workbench-secret (the docker-credential scripts are just a thin wrapper providing the resource path) - `provide-secrets.sh` fetches secrets configured in secrets.yml and passes them to the app. This is the "Secret Provider" in the design doc - `secret-receiver` receives the secret values and directs them to environment variables or file descriptors for the app to read - `vscode-secrets` is a sample vscode app that reads a secret named `example-secret` and stores it in environment variable `EXAMPLE_SECRET` PHP-127691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See linked verily1 PR for ordering of when the scripts will be called.
docker-auth-secrets.shregisters docker-credential-workbench-secret to be used when pulling a package from one of the "dockerRepository" secrets. This must be called after git-clone-devcontainer since it needs to read the secret from the devcontainer directorydocker-credential-secrets.shis the script behind docker-credential-workbench-secret (the docker-credential scripts are just a thin wrapper providing the resource path)provide-secrets.shfetches secrets configured in secrets.yml and passes them to the app. This is the "Secret Provider" in the design docsecret-receiverreceives the secret values and directs them to environment variables or file descriptors for the app to readvscode-secretsis a sample vscode app that reads a secret namedexample-secretand stores it in environment variableEXAMPLE_SECRETPHP-127691