Skip to content

Reorder devcontainer failure handler to address race setting status #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pantherman594 merged 1 commit into from
Apr 28, 2026
Merged

Reorder devcontainer failure handler to address race setting status #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions startupscript/butane/devcontainer-failure-handler.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,16 @@ echo "failed: $(date)" >> "${RETRY_FILE}"
# Check if number of retries have exceeded maximum
num_retries="$(wc -l < "${RETRY_FILE}")"
if [[ "${num_retries}" -ge "${RETRY_COUNT}" ]]; then
# Stop the service
systemctl stop devcontainer.service

# Log failure
source /home/core/metadata-utils.sh
set_metadata "startup_script/status" "ERROR"
error_message=$(get_guest_attribute "startup_script/message" "")
if [[ -z "${error_message}" ]]; then
set_metadata "startup_script/message" "There was an error launching your custom container on the VM. Please try recreating the VM."
fi
# Stop the service
systemctl stop devcontainer.service

if [[ "$SHUTDOWN_ON_FAILURE" == "true" ]]; then
# Sleep for a bit in case logs need to be captured
Expand Down
Loading