fix: restore vfox and mise PR regression coverage#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make PR CI exercise the actual plugin changes across both
vfoxandmise, and fix the recentmiseregression where Elixir source builds could not finderlcduring install hooks.Changes
mise E2E testsPR triggers to cover plugin code and workflow changesmiseCI so PR runs validate the branch under reviewmiseand inject the resolved Erlangbindirectory into the Elixir build command when neededvfox E2E testsPR triggers to cover plugin code and workflow changesvfoxPR runs fetch the plugin archive from the current PR head SHA instead of a branch refmacOSrunner condition invfox E2E testsfail-fastso platform regressions report independentlyTesting
e2e_tests (ubuntu-22.04)e2e_tests (macos-latest)e2e_tests (windows-2022)mise_e2e_tests (ubuntu-22.04)mise_e2e_tests (macos-latest)misePR run reproduced the macOSmake: erlc: No such file or directoryfailuremisePR run passed on both Ubuntu and macOSContext
The recent failures were not caused by a repo logic change alone. The breakage showed up after
misechanged how vfox install-hook environments are built, which exposed this plugin's assumption thaterlcwould already be onPATH. This PR fixes that assumption and also makes sure future PRs run the fullvfoxandmiseregression coverage against the code actually under review.