Skip to content

fix: restore vfox and mise PR regression coverage#18

Merged
yeshan333 merged 3 commits into
mainfrom
fix/mise-pr-trigger
Jun 17, 2026
Merged

fix: restore vfox and mise PR regression coverage#18
yeshan333 merged 3 commits into
mainfrom
fix/mise-pr-trigger

Conversation

@yeshan333

@yeshan333 yeshan333 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

Make PR CI exercise the actual plugin changes across both vfox and mise, and fix the recent mise regression where Elixir source builds could not find erlc during install hooks.

Changes

  • expand mise E2E tests PR triggers to cover plugin code and workflow changes
  • link the checked-out repository as a local plugin in mise CI so PR runs validate the branch under review
  • declare the Elixir plugin's Erlang hook dependency for mise and inject the resolved Erlang bin directory into the Elixir build command when needed
  • expand vfox E2E tests PR triggers to cover plugin code and workflow changes
  • make vfox PR runs fetch the plugin archive from the current PR head SHA instead of a branch ref
  • fix the macOS runner condition in vfox E2E tests
  • disable matrix fail-fast so platform regressions report independently

Testing

  • latest PR checks now include all five regression jobs:
    • e2e_tests (ubuntu-22.04)
    • e2e_tests (macos-latest)
    • e2e_tests (windows-2022)
    • mise_e2e_tests (ubuntu-22.04)
    • mise_e2e_tests (macos-latest)
  • previous mise PR run reproduced the macOS make: erlc: No such file or directory failure
  • after the fix, the subsequent mise PR run passed on both Ubuntu and macOS

Context

The recent failures were not caused by a repo logic change alone. The breakage showed up after mise changed how vfox install-hook environments are built, which exposed this plugin's assumption that erlc would already be on PATH. This PR fixes that assumption and also makes sure future PRs run the full vfox and mise regression coverage against the code actually under review.

@yeshan333 yeshan333 changed the title fix: validate local plugin in mise PR workflow fix: restore vfox and mise PR regression coverage Jun 17, 2026

@yeshan333 yeshan333 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeshan333 yeshan333 merged commit ed0cbcf into main Jun 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant