Skip to content

Commit 04b4dc4

Browse files
Copilotbytemain
andcommitted
Move -fx suffix after distribution name (e.g., zulu-fx instead of fx-zulu)
Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com>
1 parent a9f03e1 commit 04b4dc4

File tree

5 files changed

+25
-30
lines changed

5 files changed

+25
-30
lines changed

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Support for multiple JDK distributions, such as: Oracle, Graalvm, Eclipse & more
99

1010
# Usage
1111

12-
**Parameter Format**: `x.y.z-distribution` or `x.y.z-fx-distribution` (for JavaFX bundled versions)
12+
**Parameter Format**: `x.y.z-distribution` or `x.y.z-distribution-fx` (for JavaFX bundled versions)
1313

1414
```shell
1515
# add plugin for vfox
@@ -21,9 +21,9 @@ vfox install java@17.0.17-tem # Temurin
2121
vfox install java@17.0.17-zulu # Zulu
2222
vfox install java@17-graal # GraalVM (latest 17.x)
2323

24-
# install JavaFX bundled versions (use -fx suffix)
25-
vfox install java@21.0.5-fx-zulu # Zulu with JavaFX
26-
vfox install java@21.0.5-fx-librca # Liberica with JavaFX
24+
# install JavaFX bundled versions (use -fx suffix after distribution)
25+
vfox install java@21.0.5-zulu-fx # Zulu with JavaFX
26+
vfox install java@21.0.5-librca-fx # Liberica with JavaFX
2727

2828
# view all available versions
2929
vfox search java # view all openjdk versions
@@ -34,19 +34,19 @@ vfox search java graal # view all graalvm versions
3434

3535
## JavaFX Support
3636

37-
Some distributions provide JDK versions bundled with JavaFX. These versions are displayed with the `-fx` suffix in the version list and marked with "JavaFX" in the notes. To install a JavaFX bundled version, add `-fx` to the version string:
37+
Some distributions provide JDK versions bundled with JavaFX. These versions are displayed with the `-fx` suffix after the distribution name in the version list and marked with "JavaFX" in the notes. To install a JavaFX bundled version, add `-fx` after the distribution name:
3838

3939
```shell
4040
# List versions (JavaFX versions will show -fx suffix)
4141
vfox search java zulu
4242
# Example output:
4343
# 21.0.5-zulu
44-
# 21.0.5-fx-zulu # JavaFX
44+
# 21.0.5-zulu-fx # JavaFX
4545
# 17.0.13-zulu
46-
# 17.0.13-fx-zulu # JavaFX
46+
# 17.0.13-zulu-fx # JavaFX
4747

4848
# Install JavaFX bundled version
49-
vfox install java@21.0.5-fx-zulu
49+
vfox install java@21.0.5-zulu-fx
5050
```
5151

5252
# Supported JDK Distributions

README_CN.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
# 使用
1010

11-
**参数格式**: `x.y.z-distribution``x.y.z-fx-distribution` (带 JavaFX 的版本)
11+
**参数格式**: `x.y.z-distribution``x.y.z-distribution-fx` (带 JavaFX 的版本)
1212

1313
```shell
1414
# 添加插件
@@ -18,9 +18,9 @@ vfox add java
1818
vfox install java@x.y.z # 默认使用openjdk
1919
vfox install java@x.y.z-graal # 使用graalvm
2020

21-
# 安装带 JavaFX 的版本 (使用 -fx 后缀)
22-
vfox install java@21.0.5-fx-zulu # 带 JavaFX 的 Zulu
23-
vfox install java@21.0.5-fx-librca # 带 JavaFX 的 Liberica
21+
# 安装带 JavaFX 的版本 (在发行版名称后添加 -fx 后缀)
22+
vfox install java@21.0.5-zulu-fx # 带 JavaFX 的 Zulu
23+
vfox install java@21.0.5-librca-fx # 带 JavaFX 的 Liberica
2424

2525
# 查看所有可用版本
2626
vfox search java all # 查看所有sdk版本
@@ -30,19 +30,19 @@ vfox search java graal # 查看所有graalvm版本
3030

3131
## JavaFX 支持
3232

33-
部分发行版提供了捆绑 JavaFX 的 JDK 版本。这些版本在版本列表中会显示 `-fx` 后缀,并在备注中标注 "JavaFX"。安装带 JavaFX 的版本时,需要在版本字符串中添加 `-fx`
33+
部分发行版提供了捆绑 JavaFX 的 JDK 版本。这些版本在版本列表中会在发行版名称后显示 `-fx` 后缀,并在备注中标注 "JavaFX"。安装带 JavaFX 的版本时,需要在发行版名称后添加 `-fx`
3434

3535
```shell
3636
# 查看版本列表 (带 JavaFX 的版本会显示 -fx 后缀)
3737
vfox search java zulu
3838
# 示例输出:
3939
# 21.0.5-zulu
40-
# 21.0.5-fx-zulu # JavaFX
40+
# 21.0.5-zulu-fx # JavaFX
4141
# 17.0.13-zulu
42-
# 17.0.13-fx-zulu # JavaFX
42+
# 17.0.13-zulu-fx # JavaFX
4343

4444
# 安装带 JavaFX 的版本
45-
vfox install java@21.0.5-fx-zulu
45+
vfox install java@21.0.5-zulu-fx
4646
```
4747

4848
# 支持的JDK发行版

hooks/available.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,18 @@ function PLUGIN:Available(ctx)
3131
local v = jdk.java_version
3232
local short = jdk.short
3333

34-
-- Add -fx suffix for JavaFX bundled versions
34+
-- Add -fx suffix for JavaFX bundled versions (after distribution name)
3535
local fx_suffix = ""
3636
if jdk.javafx_bundled == true then
3737
fx_suffix = "-fx"
3838
end
3939

4040
if query == "all" then
41-
v = v .. fx_suffix .. "-" .. short
41+
v = v .. "-" .. short .. fx_suffix
4242
elseif query == "open" then
4343
v = v .. fx_suffix
4444
else
45-
v = v .. fx_suffix .. "-" .. distribution.short_name
45+
v = v .. "-" .. distribution.short_name .. fx_suffix
4646
end
4747

4848
if not seen[v] then

hooks/pre_install.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function PLUGIN:PreInstall(ctx)
4040
-- checksum = httpGet(info.checksum_uri, "Failed to fetch checksum")
4141
-- end
4242

43-
-- Build final version string with fx suffix if needed
43+
-- Build final version string with fx suffix if needed (after distribution name)
4444
local fx_suffix = ""
4545
if jdk.javafx_bundled == true then
4646
fx_suffix = "-fx"
@@ -50,7 +50,7 @@ function PLUGIN:PreInstall(ctx)
5050
if distribution_version.distribution.short_name == "open" then
5151
finalV = jdk.java_version .. fx_suffix
5252
else
53-
finalV = jdk.java_version .. fx_suffix .. "-" .. distribution_version.distribution.short_name
53+
finalV = jdk.java_version .. "-" .. distribution_version.distribution.short_name .. fx_suffix
5454
end
5555
return {
5656
-- [info.checksum_type] = checksum,

lib/distribution_version.lua

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,11 @@ function distribution_version.parse_version (arg)
6161
local distribution
6262
local javafx_bundled = false
6363

64-
-- Check for "fx" in any part and remove it, setting javafx_bundled flag
65-
local filtered_parts = {}
66-
for _, part in ipairs(version_parts) do
67-
if part == "fx" then
68-
javafx_bundled = true
69-
else
70-
table.insert(filtered_parts, part)
71-
end
64+
-- Check if the last part is "fx" and remove it, setting javafx_bundled flag
65+
if version_parts[#version_parts] == "fx" then
66+
javafx_bundled = true
67+
table.remove(version_parts)
7268
end
73-
version_parts = filtered_parts
7469

7570
if not version_parts[2] then
7671
-- no parts, check if we got a distribution name without version

0 commit comments

Comments
 (0)