fix: normalize folded headers before SMTP send#249
Open
rawvoid wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for sharing this PR. Have you signed the Eclipse Contributor Agreement and signed-off your commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes folded header values being sent with bare LF during SMTP DATA.
How To Reproduce
Unicode folding test ⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐⭐.in the header value, andSMTPSendMailappended" "only at the end of the full header line.Subjectheader, and the server could reject the message during DATA.Fix
CRLFbefore writing headers to the SMTP socket.Standards Basis
CRLFas the line terminator and not transmit bareCRorLFin message text.CRLF, and header folding is defined as insertingCRLFbefore whitespace.Verification
mvn -q -Dtest=MailHeaderLineBreakTest,MailSubjectTest,DKIMSignerTest testmvn -q -Dtest=MailWithDKIMSignTest#testMailSimpleSimplePlain+testMailRelaxedRelaxedPlain,DKIMSignerTest test