Pass 404 and other errors

Author: Valeriy Mukhtarulin

NEWS.md

@@ -1,6 +1,10 @@
 CHANGES
 =======
 
+3.0.0
+-----
+* Return proper 404 error
+
 3.0.0
 -----
 * Use v8 by default, lower timeout

tests/test_errors.py

@@ -19,3 +19,18 @@ def test_bad_request():
 
     with pytest.raises(BadRequest, match="400, Bad or missing parameters") as e:
         raise VeryfiClientError.from_response(response)
+
+
+@responses.activate
+def test_not_found():
+    url = f"{Client.BASE_URL}v7/partner/documents"
+    responses.add(
+        responses.PUT,
+        url,
+        json={"status": "fail", "error": "Document not found"},
+        status=404,
+    )
+    response = requests.put(url)
+
+    with pytest.raises(VeryfiClientError, match="404, Document not found") as e:
+        raise VeryfiClientError.from_response(response)

veryfi/errors.py

@@ -20,18 +20,8 @@ def from_response(raw_response):
             'error': 'Human readable error description.'
         }
         """
-        json_response = raw_response.json()
-        # TODO Add Error Codes to API response
-        # code = error_info.get("code", "")
-
-        try:
-            error_cls = _error_map[raw_response.status_code]
-        except KeyError:
-            raise NotImplementedError(
-                "Unknown error Please contact customer support at support@veryfi.com."
-            )
-        else:
-            return error_cls(raw_response, **raw_response.json())
+        error_cls = _error_map.get(raw_response.status_code) or VeryfiClientError
+        return error_cls(raw_response, **raw_response.json())
 
 
 class UnauthorizedAccessToken(VeryfiClientError):
@@ -54,6 +44,10 @@ class InternalError(VeryfiClientError):
     pass
 
 
+class InternalError(VeryfiClientError):
+    pass
+
+
 _error_map = {
     400: BadRequest,
     401: UnauthorizedAccessToken,