Skip to content

fix(recall): preserve vector fetch limit floor#210

Merged
jack-arturo merged 1 commit into
fix/recall-overfetch-and-artifact-exclusionfrom
fix/pr205-fetch-cap-floor
Jul 2, 2026
Merged

fix(recall): preserve vector fetch limit floor#210
jack-arturo merged 1 commit into
fix/recall-overfetch-and-artifact-exclusionfrom
fix/pr205-fetch-cap-floor

Conversation

@jack-arturo

Copy link
Copy Markdown
Member

Summary

  • Preserve the caller's requested vector fetch limit even when RECALL_VECTOR_FETCH_CAP is configured below limit.
  • Add a regression test for the cap-under-limit edge case.
  • Keeps the cap as an over-fetch ceiling without allowing it to make recall narrower than legacy behavior.

Context

Follow-up to PR #205. The original over-fetch implementation used min(per_query_limit * RECALL_VECTOR_OVERFETCH, RECALL_VECTOR_FETCH_CAP), which can ask Qdrant for fewer candidates than the requested response limit when the cap is set low.

Tests

Risk Notes

  • This is a narrow guardrail around the new config; it should only affect deployments that lower RECALL_VECTOR_FETCH_CAP below requested limit.
  • No merge performed.

@jack-arturo

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 833cbbb558

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jack-arturo jack-arturo merged commit 8abbb2f into fix/recall-overfetch-and-artifact-exclusion Jul 2, 2026
1 check passed
@jack-arturo jack-arturo deleted the fix/pr205-fetch-cap-floor branch July 2, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant