fix(profile): map 20GBD9901 to Stream Deck + (4 dials + 4x2 keypad)

[asasin235]

Summary

The device model ID 20GBD9901 is currently mapped in MODEL_LAYOUTS to the Stream Deck Neo with a keypad-only layout:

# Stream Deck Neo (8 keys + touchscreen)
"20GBD9901": {KEYPAD: (4, 2)},

But an in-the-wild profile manifest written by the Elgato desktop app for this model contains a full Type: "Encoder" controller with 4 dial actions at positions 0,0…3,0 plus an 800×100 touchstrip Background image — matching the original Stream Deck + (2022), not the Neo (which has no rotary encoders).

Today, trying to write an encoder button to a 20GBD9901 profile raises:

ProfileValidationError: Device model does not expose a 'Encoder' controller.

This PR corrects the mapping so it matches the hardware actually in use.

The existing # NOTE in MODEL_LAYOUTS predicted this exact case and spelled out the fix:

…add that model's ID here (with ENCODER: (4, 1) and KEYPAD: (4, 2)) when seen.

Evidence

Redacted excerpts from a real 20GBD9901 profile written by the Elgato desktop app:

ProfilesV3/<profile>.sdProfile/manifest.json:

{"Device": {"Model": "20GBD9901", "UUID": "@(1)[4057/132/…]"}, …}

ProfilesV3/<profile>.sdProfile/Profiles/<page>/manifest.json:

{
  "Controllers": [
    {
      "Type": "Encoder",
      "Background": "Images/…png",
      "Actions": {
        "0,0": {"Name": "Hotkey", …},
        "1,0": {"Name": "Multimedia", …},
        "2,0": {"Name": "Brightness", …},
        "3,0": {"Name": "Hotkey", …}
      }
    },
    {"Type": "Keypad", "Actions": {"0,0": …, "1,0": …, /* 8 entries across 4x2 */}}
  ]
}

Changes

• profile_manager.py — replace the Neo mapping for 20GBD9901 with the correct Stream Deck + layout (KEYPAD: (4, 2), ENCODER: (4, 1)); remove the now-stale # NOTE that foreshadowed this change.
• profile_manager.py — update MODEL_NAMES["20GBD9901"] from Stream Deck Neo → Stream Deck + so streamdeck_read_profiles reports the correct model name.
• tests/test_profile_manager.py — add a sample_profiles_plus fixture modeled on sample_profiles_plus_xl, plus three regression tests:
  • test_plus_device_exposes_encoder_layout — read_page returns {keypad: 4x2, encoder: 4x1}
  • test_plus_device_accepts_encoder_writes — writing an encoder button to a 20GBD9901 profile succeeds and lands in the Encoder controller
  • test_plus_device_reports_correct_model_name — list_profiles surfaces ModelName: "Stream Deck +"

Context — related work

• feat(profile): preserve encoder controller + Stream Deck + XL layout #15 added the multi-controller write path this PR completes for the original Plus
• feat(touchstrip): per-segment icon and background on Stream Deck + / + XL #20 added per-segment encoder icon + touchstrip background writes
• feat(touchstrip): expose $X1/$A0/$A1/$B1/$B2/$C1 encoder layouts #21 added encoder layout variants

The encoder-writing machinery already supports this device fully — it was just being rejected at the model-lookup layer before reaching any of it.

Test plan

• uv run pytest tests/ -q — 84 passed (81 existing + 3 new)
• uv run ruff check profile_manager.py tests/test_profile_manager.py — clean
• End-to-end: installed this branch into a venv, ran a profile-writing script against a real 20GBD9901 profile — previously errored on every page with Device model does not expose a 'Encoder' controller, now writes successfully.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes incorrect model metadata for device model 20GBD9901, aligning the expected controller layout with real-world Stream Deck + profile manifests so encoder/dial actions can be read/written without validation errors.

Changes:

• Update MODEL_LAYOUTS for 20GBD9901 to include ENCODER: (4, 1) alongside KEYPAD: (4, 2).
• Update MODEL_NAMES["20GBD9901"] to report Stream Deck + instead of Stream Deck Neo.
• Add regression tests/fixture to ensure encoder layouts are exposed, encoder writes succeed, and the correct model name is reported.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
profile_manager.py	Corrects 20GBD9901 layout + human-readable name to match Stream Deck + hardware capabilities.
tests/test_profile_manager.py	Adds a Stream Deck + sample profile fixture and three regression tests covering layout exposure, encoder writes, and model naming.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jack-arturo]

@copilot apply changes based on the comments in this thread

[jack-arturo]

Thanks @asasin235 ! 🙏