fix: os.execute(installCmd)

Author: Artemeey

bin/install-windows-php.ps1

@@ -140,27 +140,86 @@ Function Get-PhpExtras {
     return $false
 }
 
+Function Write-PathInfo {
+    param(
+        [Parameter(Mandatory = $true)][string]$Label,
+        [Parameter(Mandatory = $true)][string]$Path
+    )
+
+    $exists = Test-Path $Path
+    if ($exists) {
+        $item = Get-Item $Path -ErrorAction SilentlyContinue
+        $kind = if ($item -and $item.PSIsContainer) { "Directory" } elseif ($item) { "File" } else { "Unknown" }
+        Write-Host ("{0}: {1} (exists=True, kind={2})" -f $Label, $Path, $kind)
+    } else {
+        Write-Host ("{0}: {1} (exists=False)" -f $Label, $Path)
+    }
+}
+
+Function Write-ValueInfo {
+    param(
+        [Parameter(Mandatory = $true)][string]$Label,
+        [Parameter(Mandatory = $true)]$Value
+    )
+
+    $typeName = if ($null -eq $Value) { "<null>" } else { $Value.GetType().FullName }
+    Write-Host ("{0}: {1} (type={2})" -f $Label, $Value, $typeName)
+}
+
 $tempFile = [IO.Path]::ChangeExtension([IO.Path]::GetTempFileName(), '.zip')
 
 try {
-    if (-not (Test-Path $CustomPath)) { New-Item -ItemType Directory -Path $CustomPath | Out-Null }
+    Set-Location -LiteralPath $env:TEMP
+    Write-ValueInfo "Version" $Version
+    Write-ValueInfo "Arch" $Arch
+    Write-ValueInfo "ThreadSafe" $ThreadSafe
+    Write-ValueInfo "Timezone" $Timezone
+    Write-PathInfo "CustomPath input" $CustomPath
+    Write-PathInfo "Temp archive file" $tempFile
+
+    if (-not (Test-Path $CustomPath)) {
+        Write-Host "Creating CustomPath directory: $CustomPath"
+        New-Item -ItemType Directory -Path $CustomPath | Out-Null
+    }
 
     $Semver = $Version
     $installDirectory = [Environment]::ExpandEnvironmentVariables($CustomPath)
 
-    Write-Host "Downloading PHP $Semver ($Arch, $(if($ThreadSafe){'ts'}else{'nts'})) -> $installDirectory"
+    Write-PathInfo "Install directory" $installDirectory
+    Write-Host ("Downloading PHP {0} ({1}, {2}) -> {3}" -f $Semver, $Arch, $(if($ThreadSafe){'ts'}else{'nts'}), $installDirectory)
     Get-PhpFromUrl $Semver $Semver $Arch $ThreadSafe $tempFile
+    Write-PathInfo "Downloaded archive" $tempFile
     Expand-Archive -Path $tempFile -DestinationPath $installDirectory -Force -ErrorAction Stop
+    Write-Host "Archive expanded to: $installDirectory"
+    Write-Host "Top-level contents after unpack:"
+    Get-ChildItem -LiteralPath $installDirectory -Force | ForEach-Object {
+        Write-Host ("  {0} [{1}]" -f $_.FullName, $(if ($_.PSIsContainer) { "Directory" } else { "File" }))
+    }
+
+    $phpExe = Join-Path $installDirectory "php.exe"
+    $phpIniProdAfterUnpack = Join-Path $installDirectory "php.ini-production"
+    $phpIniRecommendedAfterUnpack = Join-Path $installDirectory "php.ini-recommended"
+    $extDirAfterUnpack = Join-Path $installDirectory "ext"
+
+    Write-PathInfo "php.exe after unpack" $phpExe
+    Write-PathInfo "php.ini-production after unpack" $phpIniProdAfterUnpack
+    Write-PathInfo "php.ini-recommended after unpack" $phpIniRecommendedAfterUnpack
+    Write-PathInfo "ext directory after unpack" $extDirAfterUnpack
 
     # Download extras package (additional extension DLLs)
     if ($InstallExtras) {
         Write-Host "Downloading PHP extras package..."
         $tempExtras = [IO.Path]::ChangeExtension([IO.Path]::GetTempFileName(), '.zip')
         try {
+            Write-PathInfo "Temp extras archive" $tempExtras
             $found = Get-PhpExtras $Semver $Semver $Arch $tempExtras
             if ($found) {
                 Expand-Archive -Path $tempExtras -DestinationPath $installDirectory -Force -ErrorAction Stop
                 Write-Host "Extras installed successfully."
+                Write-Host "Top-level contents after extras unpack:"
+                Get-ChildItem -LiteralPath $installDirectory -Force | ForEach-Object {
+                    Write-Host ("  {0} [{1}]" -f $_.FullName, $(if ($_.PSIsContainer) { "Directory" } else { "File" }))
+                }
             } else {
                 Write-Host "Warning: No extras package found for PHP $Semver - skipping."
             }
@@ -172,6 +231,7 @@ try {
     }
 
     $extDir = Join-Path $installDirectory "ext"
+    Write-PathInfo "ext directory" $extDir
 
     # Warn if ext/ directory is missing (incomplete build)
     if (-not (Test-Path $extDir)) {
@@ -183,15 +243,20 @@ try {
     $phpIniProd = Join-Path $installDirectory "php.ini-production"
     if (-not (Test-Path $phpIniProd)) { $phpIniProd = Join-Path $installDirectory "php.ini-recommended" }
     $phpIni = Join-Path $installDirectory "php.ini"
+    Write-PathInfo "php.ini-production/recommended" $phpIniProd
+    Write-PathInfo "php.ini target" $phpIni
 
     if (Test-Path $phpIniProd) {
         Copy-Item $phpIniProd $phpIni -Force
+        Write-Host "Copied php.ini template to: $phpIni"
 
         (Get-Content $phpIni) -replace '^extension_dir = "./"',     "extension_dir = `"$extDir`"" | Set-Content $phpIni
         (Get-Content $phpIni) -replace ';\s?extension_dir = "ext"', "extension_dir = `"$extDir`"" | Set-Content $phpIni
         (Get-Content $phpIni) -replace ';\s?date.timezone =',       "date.timezone = `"$Timezone`"" | Set-Content $phpIni
+        Write-Host "Updated php.ini with extension_dir and timezone."
 
         if (Test-Path $extDir) {
+            Write-Host "Probing static extensions from: $phpExe"
             $staticExtensions = (& "$installDirectory\php.exe" -m 2>$null) -split "`n" |
                 ForEach-Object { $_.Trim().ToLower() }
 
@@ -215,8 +280,10 @@ try {
             foreach ($ext in $zendExtensions) {
                 $dllPath = Join-Path $extDir "php_$ext.dll"
                 $isStatic = $staticExtensions -contains $ext.ToLower()
+                Write-PathInfo "Zend extension candidate" $dllPath
                 if (-not $isStatic -and (Test-Path $dllPath)) {
                     (Get-Content $phpIni) -replace "^;zend_extension=$ext", "zend_extension=$ext" | Set-Content $phpIni
+                    Write-Host "Enabled zend extension: $ext"
                 }
             }
         }
@@ -236,6 +303,7 @@ try {
     }
 
     Set-PathEntryFirst -Target 'User' -Entry $installDirectory
+    Write-Host "PATH updated with: $installDirectory"
 
     Write-Host ""
     Write-Host "Installed PHP $Semver directly to $installDirectory"

hooks/post_install.lua

@@ -33,9 +33,8 @@ function install_php_for_windows(sdkPath, version)
     major, minor = tonumber(major) or 0, tonumber(minor) or 0
 
     local scriptPath = assert(RUNTIME.pluginDirPath .. "\\bin\\install-windows-php.ps1")
-    local installCmd = string.format([[
-        powershell -NoProfile -ExecutionPolicy Bypass -Command "Set-Location -LiteralPath $env:TEMP; & '%s' -Version '%s' -Arch x64 -CustomPath '%s'"
-    ]],
+    local installCmd = string.format(
+        [[powershell -NoProfile -ExecutionPolicy Bypass -File %s -Version %s -Arch x64 -CustomPath %s]],
         scriptPath,
         version,
         sdkPath