fix(windows): resolve PHP install failures and prevent false CI coverage (#65)

Co-authored-by: Rózsa Zoltán <67325669+rozsazoltan@users.noreply.github.com>
Signed-off-by: Artemeey <artemeey.ru@mail.ru>

Author: Artemeey

.github/scripts/ci-checks.rs

@@ -207,6 +207,10 @@ fn check_installed_tools(args: &[String]) -> Result<(), String> {
 
     mise_exec(&["php", "--version"], false)?;
 
+    if runner_os == "Windows" {
+        require_windows_spaced_mise_install_path()?;
+    }
+
     let php_version_raw = mise_exec(&["php", "-r", "echo PHP_VERSION;"], true)?;
     let php_version_text = php_version_raw.trim();
     let php_version = PhpVersion::parse(php_version_text)?;
@@ -267,6 +271,45 @@ fn check_installed_tools(args: &[String]) -> Result<(), String> {
     Ok(())
 }
 
+
+fn require_windows_spaced_mise_install_path() -> Result<(), String> {
+    let mise_data_dir = env::var("MISE_DATA_DIR")
+        .map_err(|_| "MISE_DATA_DIR must be set for Windows install smoke tests".to_string())?;
+
+    if !mise_data_dir.contains(' ') {
+        return Err(format!(
+            "Windows install smoke tests must use a spaced MISE_DATA_DIR, got {mise_data_dir:?}"
+        ));
+    }
+
+    let php_binary = mise_exec(&["php", "-r", "echo PHP_BINARY;"], true)?;
+    let php_binary = normalize_windows_path(php_binary.trim());
+    let mise_data_dir = normalize_windows_path(mise_data_dir.trim());
+
+    if !php_binary.contains(' ') {
+        return Err(format!(
+            "PHP_BINARY should contain a space to cover Windows quoting regressions, got {php_binary:?}"
+        ));
+    }
+
+    if !php_binary.starts_with(&mise_data_dir) {
+        return Err(format!(
+            "PHP_BINARY should be installed under MISE_DATA_DIR. MISE_DATA_DIR={mise_data_dir:?}, PHP_BINARY={php_binary:?}"
+        ));
+    }
+
+    println!("Windows install path is under spaced MISE_DATA_DIR: {php_binary}");
+    Ok(())
+}
+
+fn normalize_windows_path(value: &str) -> String {
+    value
+        .trim_matches('"')
+        .replace('/', "\\")
+        .trim_end_matches('\\')
+        .to_ascii_lowercase()
+}
+
 fn require_php_extension(extension: &str, reason: &str) -> Result<(), String> {
     let modules = mise_exec(&["php", "-m"], true)?;
     let found = modules

.github/workflows/cache.yml

@@ -10,6 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: write
+      issues: write
 
     steps:
       - name: Checkout default branch (for repo access)
@@ -43,8 +44,27 @@ jobs:
           python3 << 'EOF'
           import urllib.request
           import json
+          import os
           import re
 
+          def read_existing_versions():
+              if not os.path.exists("versions.txt"):
+                  return []
+
+              with open("versions.txt", "r") as f:
+                  return [line.strip() for line in f if line.strip()]
+
+          def series_key(version):
+              m = re.match(r'^(\d+)\.(\d+)\.', version)
+              if not m:
+                  return None
+
+              return f"{m.group(1)}.{m.group(2)}"
+
+          def major_key(version):
+              m = re.match(r'^(\d+)\.', version)
+              return m.group(1) if m else None
+
           def fetch_tags():
               tags = []
               page = 1
@@ -84,6 +104,10 @@ jobs:
               suffix_order = 0 if not suffix else -1
               return (major, minor, patch, suffix_order)
 
+          old_versions = read_existing_versions()
+          old_series = {series_key(v) for v in old_versions if series_key(v)}
+          old_majors = {major_key(v) for v in old_versions if major_key(v)}
+
           tags = fetch_tags()
 
           seen = set()
@@ -99,9 +123,28 @@ jobs:
           with open("versions.txt", "w") as f:
               f.write("\n".join(versions) + "\n")
 
+          new_series = []
+          if old_versions:
+              latest_by_series = {}
+              for version in versions:
+                  series = series_key(version)
+                  if series and series not in old_series and series not in latest_by_series:
+                      latest_by_series[series] = version
+
+              for series, representative in sorted(latest_by_series.items(), key=lambda item: [int(part) for part in item[0].split(".")]):
+                  major = series.split(".", 1)[0]
+                  scope = "major" if major not in old_majors else "minor"
+                  new_series.append((scope, series, representative))
+
+          with open("new-windows-series.txt", "w") as f:
+              for scope, series, representative in new_series:
+                  f.write(f"{scope}\t{series}\t{representative}\n")
+
           print(f"Fetched {len(versions)} versions.")
+          print(f"Detected {len(new_series)} new PHP major/minor series.")
           EOF
 
+
       - name: Commit to cache branch if changed
         run: |
           git config user.name  "github-actions[bot]"
@@ -115,3 +158,59 @@ jobs:
             git commit -m "chore: bump php versions cache (+${ADDED} lines)"
             git push origin cache
           fi
+
+      - name: Open Windows installer maintenance issues
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        shell: bash
+        run: |
+          set -euo pipefail
+
+          if [ ! -s new-windows-series.txt ]; then
+            echo "No new PHP major/minor series detected."
+            exit 0
+          fi
+
+          while IFS=$'\t' read -r scope series representative; do
+            [ -n "${series:-}" ] || continue
+
+            if [ "$scope" = "major" ]; then
+              title="Review Windows PHP installer mapping for PHP ${series} (new major)"
+            else
+              title="Review Windows PHP installer mapping for PHP ${series}"
+            fi
+
+            existing="$(
+              ISSUE_TITLE="$title" gh issue list \
+                --state open \
+                --search "${title} in:title" \
+                --json title \
+                | python3 -c 'import json, os, sys; title = os.environ["ISSUE_TITLE"]; print(sum(1 for issue in json.load(sys.stdin) if issue.get("title") == title))'
+            )"
+
+            if [ "$existing" != "0" ]; then
+              echo "Issue already exists: $title"
+              continue
+            fi
+
+            body_file="$(mktemp)"
+            cat > "$body_file" <<EOF
+The PHP versions cache detected a new PHP ${scope} series: ${series}.
+
+First detected version: ${representative}
+
+Please review whether `lib/windows_php.lua` needs to be updated against the official PHP Windows installer script:
+https://www.php.net/include/download-instructions/windows.ps1
+
+Focus areas:
+- Visual C++ toolset mapping (`vs16`, `vs17`, future values)
+- x64/x86 availability and fallback rules
+- release vs QA/archive URL behavior
+- ZIP naming conventions for NTS Windows builds
+
+This issue was opened automatically by the PHP versions cache workflow because new major/minor PHP series can require Windows installer mapping changes.
+EOF
+
+            gh issue create --title "$title" --body-file "$body_file"
+            rm -f "$body_file"
+          done < new-windows-series.txt

.github/workflows/test.yml

@@ -344,6 +344,23 @@ jobs:
           install: false
           cache: false
 
+      - name: Configure spaced mise directories on Windows
+        if: matrix.target.kind == 'hosted' && runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $dirs = @{
+            MISE_DATA_DIR = Join-Path $env:RUNNER_TEMP 'mise data dir'
+            MISE_CACHE_DIR = Join-Path $env:RUNNER_TEMP 'mise cache dir'
+            MISE_CONFIG_DIR = Join-Path $env:RUNNER_TEMP 'mise config dir'
+            MISE_STATE_DIR = Join-Path $env:RUNNER_TEMP 'mise state dir'
+            MISE_TMP_DIR = Join-Path $env:RUNNER_TEMP 'mise tmp dir'
+          }
+
+          foreach ($item in $dirs.GetEnumerator()) {
+            New-Item -ItemType Directory -Force -Path $item.Value | Out-Null
+            "$($item.Key)=$($item.Value)" >> $env:GITHUB_ENV
+          }
+
       - name: Register plugin from PR source
         if: matrix.target.kind == 'hosted'
         run: mise plugin link php "${{ github.workspace }}"
@@ -444,6 +461,23 @@ jobs:
           install: false
           cache: false
 
+      - name: Configure spaced mise directories on Windows
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $dirs = @{
+            MISE_DATA_DIR = Join-Path $env:RUNNER_TEMP 'mise data dir'
+            MISE_CACHE_DIR = Join-Path $env:RUNNER_TEMP 'mise cache dir'
+            MISE_CONFIG_DIR = Join-Path $env:RUNNER_TEMP 'mise config dir'
+            MISE_STATE_DIR = Join-Path $env:RUNNER_TEMP 'mise state dir'
+            MISE_TMP_DIR = Join-Path $env:RUNNER_TEMP 'mise tmp dir'
+          }
+
+          foreach ($item in $dirs.GetEnumerator()) {
+            New-Item -ItemType Directory -Force -Path $item.Value | Out-Null
+            "$($item.Key)=$($item.Value)" >> $env:GITHUB_ENV
+          }
+
       - name: Register plugin from PR source
         run: mise plugin link php "${{ github.workspace }}"