fix(windows): resolve PHP install failures and prevent false CI coverage

[Artemeey]

Command:

mise install php@8.5

Error message:

mise ERROR Failed to install vfox:php@8.5: runtime error: ...ppData\Local\mise\plugins\php\hooks/post_install.lua:44: 

Failed to install PHP.

💡 Tip: Run 'PHP_VERBOSE=1 mise install php@8.5.8RC1' to show commands, failure summaries, and log paths.
→ See: https://github.com/verzly/mise-php#debugging

stack traceback:
        [C]: in function 'error'
        ...ppData\Local\mise\plugins\php\hooks/post_install.lua:44: in upvalue 'install_php_for_windows'
        ...ppData\Local\mise\plugins\php\hooks/post_install.lua:22: in function 'PLUGIN.PostInstall'
        crates\vfox\src\plugin.rs:188:2: in main chunk
mise ERROR Version: 2026.6.11 windows-x64 (2026-06-16)
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information

---

Updated by @rozsazoltan

Resolves #68

Summary

This PR fixes Windows PHP installation failures and improves CI coverage so Windows install regressions are caught reliably.

The original issue was reported with:

mise install php@8.5

which failed during the Windows post-install step with:

Failed to install PHP.

A previous Windows check appeared green, but the released/latest version still failed in real Windows usage. This PR focuses on making the Windows install path work correctly and ensuring the workflow validates the same behavior users rely on.

Changes

• Reworks Windows PHP installation to avoid fragile shell-script based execution.

• Uses mise/vfox Lua runtime primitives for download, extraction, file handling, and command execution.

• Avoids temporary command runner files.

• Keeps only the required Windows runtime wrappers:

  • pie.bat
  • composer.bat

• Validates the installed php.exe after installation.

• Fixes Windows path quoting behavior, including paths containing spaces.

• Centralizes post-install package setup for PECL, PIE, PIE extensions, and Composer.

• Deduplicates shared Lua helper functions.

• Improves Windows CI coverage so install checks run under spaced mise paths and validate the actual installed PHP binary.

CI / regression coverage

The Windows workflow now exercises a more realistic install path and checks that the resolved PHP binary comes from the expected mise install directory.

This is intended to prevent misleading CI results where Windows checks pass even though the real Windows installation path is broken.

Notes

The Windows implementation intentionally avoids executing temporary command files. The generated .bat files are limited to runtime wrappers required for Windows usage of PIE and Composer.

This PR does not build PHP from source on Windows. It installs official PHP Windows ZIP releases and validates the resulting runtime.

[Artemeey]

Command os.execute(installCmd) split by spaces and ignore quotes.
This can lead to problems with paths containing spaces.

[rozsazoltan]

Thanks for working on this!

Good catch on os.execute(installCmd) splitting the command by spaces and ignoring quotes.

The change looks reasonable from my side. I'll also review my gh workflows soon. It's possible I made some assumptions during setup and didn’t fully account for Windows-specific behavior, limitations, or differences from a real Windows environment.

[Artemeey]

Info

Windows 11
Git Bash / PowerShell

mise doctor:

version: 2026.6.11 windows-x64 (2026-06-16)
shims_on_path: yes
self_update_available: yes
No problems found

Analyze

Single quotes break the command when it is executed through cmd /c.

Example: cmd /c powershell -NoProfile -ExecutionPolicy Bypass -Command 'Invoke-WebRequest -Uri https://github.com/php/pie/releases/latest/download/pie.phar -OutFile C:\Users\<user>\AppData\Local\mise\installs\php\8.5.3\pie.phar'

Double quotes escapes by os.execute() with cmd /c.

Expected: cmd /c powershell -NoProfile -ExecutionPolicy Bypass -Command "Invoke-WebRequest -Uri https://github.com/php/pie/releases/latest/download/pie.phar -OutFile C:\Users\<user>\AppData\Local\mise\installs\php\8.5.3\pie.phar"

Actual: cmd /c powershell -NoProfile -ExecutionPolicy Bypass -Command \"Invoke-WebRequest -Uri https://github.com/php/pie/releases/latest/download/pie.phar -OutFile C:\Users\<user>\AppData\Local\mise\installs\php\8.5.3\pie.phar\"

Понял. Лучше так:

Resolve

Use temporary bat files for quoted control constructs.
Selected as the most compact solution.

[Artemeey]

Error is not displayed:

mise [php] Enabled sodium
mise [php] Enabled sqlite3
mise [php] Enabled tidy
mise [php] Enabled xsl
mise [php] Enabled zip
mise [php] PHP installation complete!
mise [php] Installing PIE...
mise [php] PIE installation complete!
mise [php] Installing PIE extension: phpredis/phpredis...
mise [php] Installing PIE extension: maxmind-db/reader-ext...
mise [php] Installing PIE extension: imagick/imagick...
mise [php] PIE extensions installation complete!
mise [php] Installing Composer...
mise [php] Note: Composer installation output is hidden. Set PHP_VERBOSE=1 to see full output.
mise [php] Composer installation complete!
plugin:php      clone https://github.com/verzly/mise-php/                                                                           ✔
php@8.5.5       install                                                                                                             ✔

artem@Machenike17 MINGW64 ~/PhpstormProjects/topvisor/topvisor.com/php-fpm (master)
$ php -m | grep phpredis

PIE extension no intsalled

Current working branch with check status code: https://github.com/Artemeey/mise-php/tree/fix-windows-php-install-quoting-2

Example get status code: https://github.com/Artemeey/mise-php/blob/d28c629261f69518521a751f0a824ad2a735a62c/lib/tools.lua#L76