fixed possible null attributeTypeDefinition for Visual Basic Winforms projects #126

Ralf1108 · Ralf1108 · commit c8527e13066b · 2024-11-26T22:45:50.000+01:00
diff --git a/src/MethodBoundaryAspect.Fody/ModuleWeaver.cs b/src/MethodBoundaryAspect.Fody/ModuleWeaver.cs
@@ -258,7 +258,10 @@ private bool WeaveMethod(
 
         private bool IsMethodBoundaryAspect(TypeDefinition attributeTypeDefinition)
         {
-            var currentType = attributeTypeDefinition.BaseType;
+            var currentType = attributeTypeDefinition?.BaseType;
+            if (currentType == null) // can be null for Visual Basic Winforms projects, see https://github.com/vescon/MethodBoundaryAspect.Fody/issues/126
+                return false;
+
             do
             {
                 if (currentType.FullName == AttributeFullNames.OnMethodBoundaryAspect)

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,10 @@ private bool WeaveMethod(`
`258`	`258`
`259`	`259`	`private bool IsMethodBoundaryAspect(TypeDefinition attributeTypeDefinition)`
`260`	`260`	`{`
`261`		`- var currentType = attributeTypeDefinition.BaseType;`
	`261`	`+ var currentType = attributeTypeDefinition?.BaseType;`
	`262`	`+ if (currentType == null) // can be null for Visual Basic Winforms projects, see https://github.com/vescon/MethodBoundaryAspect.Fody/issues/126`
	`263`	`+ return false;`
	`264`	`+`
`262`	`265`	`do`
`263`	`266`	`{`
`264`	`267`	`if (currentType.FullName == AttributeFullNames.OnMethodBoundaryAspect)`