Fix rand() constant folding purity#6147
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #6016
Description:
rand()is registered as always pure, so constant folding may evaluate it once and replace expressions such asrand() < 0.1with a fixed boolean. That makes random sampling predicates return either all rows or no rows.How do you solve it?
Mark
rand()as non-pure, consistent withrand32()andrand64(), so the optimizer does not fold it into a constant. Add a constant-folding unit test to keeprand()calls intact.Special notes for your reviewer, ex. impact of this fix, design document, etc:
Local target build was blocked before reaching this change by an existing GCC 13
-Werror=interference-sizewarning inMemoryTracker.h.git diff --checkpassed.Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: