Fix stale pid handling in nebula.service#6149
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #5998
Description:
scripts/nebula.service startrefuses to start when a stale pid file points to a live process, even if that pid has been reused by an unrelated executable. Users have to remove the stale pid file manually.How do you solve it?
When a pid file exists, verify whether the live pid belongs to the expected Nebula executable. If it is the expected executable, keep the existing "already running" behavior. If it is positively identified as another executable, remove the stale pid file and continue startup. If the process cannot be identified, keep the conservative failure behavior.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Validated with
bash -n scripts/nebula.service scripts/utils.sh,git diff --check, and a temporary service-layout repro where the pid file pointed to a live unrelatedsleepprocess.Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: