Open
Conversation
Upstream vespa-engine/gh-actions bumped ruby to 4.0.3 in jekyll-link-checker.yml, breaking htmlproofer here: the github-pages gem pulls commonmarker ~> 0.22 which caps Ruby < 4.0. Replace github-pages with a direct Jekyll dependency plus the four plugins it was implicitly providing (jekyll-feed already declared, add jekyll-redirect-from, jekyll-sitemap, jekyll-seo-tag). Jekyll stays at 3.10.0, so build behavior is unchanged. Bump ruby-version to 4.0.3 in build-pages, deploy-pages, feed workflows and the install-deps action. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bjormel
force-pushed
the
bjormel/ruby-4-htmlproofer-fix
branch
from
abb8a3a to
aa4a20e
Compare
Re-ran `bundle install` with Ruby 4.0.3 + Bundler 4.0.3 so the lockfile's RUBY VERSION and BUNDLED WITH match the version CI uses. Verified `bundle exec jekyll build` succeeds locally under 4.0.3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream vespa-engine/gh-actions bumped ruby to 4.0.3 in jekyll-link-checker.yml, breaking htmlproofer here: the github-pages gem pulls commonmarker ~> 0.22 which caps Ruby < 4.0.
Replace github-pages with a direct Jekyll dependency plus the four plugins it was implicitly providing (jekyll-feed already declared, add jekyll-redirect-from, jekyll-sitemap, jekyll-seo-tag). Jekyll stays at 3.10.0, so build behavior is unchanged. Bump ruby-version to 4.0.3 in build-pages, deploy-pages, feed workflows and the install-deps action.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com