Skip to content

🐛 fix topics in koan AboutComparison#451

Open
peetrike wants to merge 3 commits into
vexx32:mainfrom
peetrike:AboutComparison
Open

🐛 fix topics in koan AboutComparison#451
peetrike wants to merge 3 commits into
vexx32:mainfrom
peetrike:AboutComparison

Conversation

@peetrike
Copy link
Copy Markdown
Contributor

@peetrike peetrike commented Jun 8, 2021

PR Summary

fixes #450

Context

Changes

  • fix topic 'It will compare values'
  • fix topic 'It returns $true only if both inputs are $true'
  • fix topic 'It may coerce values to boolean' (in context '-or')

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@peetrike peetrike marked this pull request as ready for review June 8, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Topics solved before starting in koan AboutComparison

1 participant