feat: add Duration type for Edm.Duration, fix findMeetingTimes with proper AttendeeBase and camelCase key

Author: vgrem

examples/outlook/calendars/meeting_finder.py

@@ -14,32 +14,15 @@
 def main():
     client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
-    room_lists = client.places.room_lists.get().execute_query()
-    if room_lists:
-        for rl in room_lists:
-            print(f"Room list: {rl.display_name}  ({rl.email_address or ''})")
-            try:
-                rooms = rl.rooms.get().execute_query()
-                for room in rooms:
-                    print(f"  {room.display_name}  {room.email_address}  (capacity: {room.capacity})")
-            except Exception:
-                pass
-
     attendees = ["meganb@contoso.onmicrosoft.com"]
-    if room_lists:
-        try:
-            rooms = room_lists[0].rooms.get().execute_query()
-            attendees.extend(r.email_address for r in rooms[:2] if r.email_address)
-        except Exception:
-            pass
 
     result = client.me.find_meeting_times(
         attendees=attendees, meeting_duration=timedelta(hours=1), max_candidates=5
     ).execute_query()
-    if result and result.value and result.value.meeting_time_suggestions:
-        for s in result.value.meeting_time_suggestions:
-            slot = s.meeting_time_slot
-            print(f"  {slot.start} — {slot.end}  (confidence: {s.confidence})")
+
+    for s in result.value.meetingTimeSuggestions:
+        slot = s.meeting_time_slot
+        print(f"  {slot.start} — {slot.end}  (confidence: {s.confidence})")
 
 
 if __name__ == "__main__":

office365/directory/users/user.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import json
-from datetime import datetime
+from datetime import datetime, timedelta
 from typing import Optional
 
 from typing_extensions import Self
@@ -54,6 +54,7 @@
 from office365.outlook.calendar.attendees.base import AttendeeBase
 from office365.outlook.calendar.calendar import Calendar
 from office365.outlook.calendar.dateTimeTimeZone import DateTimeTimeZone
+from office365.outlook.calendar.email_address import EmailAddress
 from office365.outlook.calendar.events.event import Event
 from office365.outlook.calendar.events.reminder import Reminder
 from office365.outlook.calendar.group import CalendarGroup
@@ -85,6 +86,7 @@
 from office365.runtime.queries.function import FunctionQuery
 from office365.runtime.queries.service_operation import ServiceOperationQuery
 from office365.runtime.types.collections import StringCollection
+from office365.runtime.types.duration import Duration
 from office365.runtime.types.odata_property import odata
 from office365.teams.chats.collection import ChatCollection
 from office365.teams.collection import TeamCollection
@@ -396,10 +398,10 @@ def export_device_and_app_management_data(self) -> ClientResult[ClientValueColle
 
     def find_meeting_times(
         self,
-        attendees: list[AttendeeBase] | None = None,
+        attendees: list[str] | None = None,
         location_constraint: LocationConstraint | None = None,
         time_constraint: TimeConstraint | None = None,
-        meeting_duration: str | None = None,
+        meeting_duration: Duration | str | timedelta | None = None,
         max_candidates: int | None = None,
         is_organizer_optional: bool | None = None,
         return_suggestion_reasons: bool | None = None,
@@ -439,11 +441,15 @@ def find_meeting_times(
             minimum_attendee_percentage (float): The minimum required confidence for a time slot to be returned
               in the response. It is a % value ranging from 0 to 100. Optional.
         """
+        if isinstance(meeting_duration, timedelta):
+            meeting_duration = Duration.parse(meeting_duration)
         payload = {
-            "attendees": ClientValueCollection(AttendeeBase, attendees),
+            "attendees": ClientValueCollection(
+                AttendeeBase, [AttendeeBase(emailAddress=EmailAddress(a)) for a in attendees or []]
+            ),
             "locationConstraint": location_constraint,
             "timeConstraint": time_constraint,
-            "meeting_duration": meeting_duration,
+            "meetingDuration": meeting_duration,
             "maxCandidates": max_candidates,
             "isOrganizerOptional": is_organizer_optional,
             "returnSuggestionReasons": return_suggestion_reasons,

office365/runtime/types/duration.py

@@ -0,0 +1,31 @@
+from __future__ import annotations
+
+from dataclasses import dataclass
+from datetime import timedelta
+
+from office365.runtime.client_value import ClientValue
+
+
+@dataclass
+class Duration(ClientValue):
+    """Represents an Edm.Duration value (ISO 8601 duration format, e.g. PT1H)."""
+
+    value: str | None = None
+
+    @staticmethod
+    def parse(value: str | timedelta) -> Duration:
+        if isinstance(value, timedelta):
+            total_sec = int(value.total_seconds())
+            h, r = divmod(total_sec, 3600)
+            m = r // 60
+            result = "PT"
+            if h:
+                result += f"{h}H"
+            if m:
+                result += f"{m}M"
+            return Duration(value=result or "PT0M")
+        return Duration(value=value)
+
+    @property
+    def entity_type_name(self):
+        return None