fix: modernize upload_file with str | PathLike | IOBase, update example

Author: vgrem

examples/onedrive/files/upload_download.py

@@ -9,16 +9,15 @@
 from office365.graph_client import GraphClient
 from tests import test_client_id, test_password, test_tenant, test_username
 
-FILE_NAME = "Financial Sample.xlsx"
-LOCAL_PATH = Path("../../data") / FILE_NAME
+file_name = "Financial Sample.xlsx"
+local_path = Path("../../data") / file_name
 
 client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
-with open(LOCAL_PATH, "rb") as f:
-    uploaded = client.me.drive.root.upload_file(f).execute_query()
+uploaded = client.me.drive.root.upload_file(local_path).execute_query()
 
-download_path = Path(__file__).parent / FILE_NAME
+download_path = Path(__file__).parent / file_name
 with open(download_path, "wb") as f:
     uploaded.download(f).execute_query()
 
-print(f"Uploaded and downloaded: {FILE_NAME}  ({download_path.stat().st_size:,} bytes)")
+print(f"Uploaded and downloaded: {file_name}  ({download_path.stat().st_size:,} bytes)")

office365/onedrive/driveitems/driveItem.py

@@ -3,6 +3,8 @@
 import os
 from datetime import datetime
 from functools import partial
+from io import IOBase
+from os import PathLike
 from os.path import isfile, join
 from typing import IO, AnyStr, Callable
 
@@ -383,17 +385,12 @@ def _modify_query(request: RequestOptions) -> None:
         self.context.add_query(qry).before_execute(_modify_query)
         return return_type
 
-    def upload_file(self, path_or_file: str | IO) -> DriveItem:
-        """Uploads a file"""
-        if isinstance(path_or_file, IO):
-            content = path_or_file.read()
-            name = os.path.basename(path_or_file.name)
-            return self.upload(name, content)
-        else:
-            with open(path_or_file, "rb") as f:
-                content = f.read()
-            name = os.path.basename(path_or_file)
-            return self.upload(name, content)
+    def upload_file(self, path_or_file: str | PathLike | IOBase) -> DriveItem:
+        """Uploads a file (up to ~4MB; use resumable_upload for larger files)."""
+        if isinstance(path_or_file, IOBase):
+            return self.upload(os.path.basename(path_or_file.name), path_or_file.read())
+        with open(path_or_file, "rb") as f:
+            return self.upload(os.path.basename(str(path_or_file)), f.read())
 
     def upload_folder(self, path: str, file_uploaded: Callable[["DriveItem"], None] | None = None) -> DriveItem:
         """Uploads a folder"""