refactor: clean up meeting_finder.py — remove verbosity, strftime, step comments

Author: vgrem

examples/outlook/calendars/availability.py

@@ -25,10 +25,9 @@
 client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
 # 1. Find suggested meeting times
-suggestions = client.me.find_meeting_times().execute_query()
-for s in suggestions.value.meetingTimeSuggestions or []:
-    times = s.meeting_time_slot
-    print(f"  Suggested: {times.start.date_time} — {times.end.date_time}")
+result = client.me.find_meeting_times().execute_query()
+for s in result.value.meetingTimeSuggestions:
+    print(f"  Suggested: {s.meetingTimeSlot.start} — {s.meetingTimeSlot.end}")
 
 # 2. Get free/busy schedule for a user
 end_time = datetime.now()
@@ -38,7 +37,7 @@
     start_time=start_time,
     end_time=end_time,
 ).execute_query()
-for item in schedule.value or []:
-    print(f"\n  Schedule for: {item.schedule_id}")
-    for slot in item.availability_view or []:
-        print(f"    {slot.status}: {slot.start.date_time} — {slot.end.date_time}")
+for item in schedule.value:
+    print(f"\n  Schedule for: {item.scheduleId}")
+    for slot in item.scheduleItems:
+        print(f"    {slot.status}: {slot.start} — {slot.end}")

examples/outlook/calendars/meeting_finder.py

@@ -1,24 +1,11 @@
 """
-Meeting finder: suggest optimal time slots and resolve rooms.
+Find meeting times and list rooms in the tenant.
 
-Brings together three related patterns:
-  1. Find available meeting times that work for all attendees.
-  2. List room lists and rooms in the tenant.
-  3. Get free/busy schedule for a room across a time window.
-
-Useful for scheduling assistants, booking flows, and room
-management tooling.
-
-Requires delegated permissions:
-    Calendars.ReadWrite          Create and manage events
-    MailboxSettings.Read         Read user availability
-    Place.Read.All               List rooms and room lists
-
-https://learn.microsoft.com/en-us/graph/api/user-findmeetingtimes
-https://learn.microsoft.com/en-us/graph/api/resources/place
+Requires delegated permissions Calendars.ReadWrite, MailboxSettings.Read,
+Place.Read.All.
 """
 
-from datetime import datetime, timedelta, timezone
+from datetime import timedelta
 
 from office365.graph_client import GraphClient
 from tests import test_client_id, test_password, test_tenant, test_username
@@ -27,71 +14,32 @@
 def main():
     client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
-    # -- Step 1: list room lists and rooms in the tenant --
-    print("Places (room lists and rooms):")
-    all_places = client.places.get().execute_query()
-    for p in all_places:
-        print(f"  {p.display_name:45s}  type={p.entity_type_name}")
-    print()
-
-    # Try to get room lists specifically
     room_lists = client.places.room_lists.get().execute_query()
     if room_lists:
-        print("Room lists:")
         for rl in room_lists:
-            print(f"  {rl.display_name:45s}  {rl.email_address or ''}")
-            # Get rooms in this list
+            print(f"Room list: {rl.display_name}  ({rl.email_address or ''})")
             try:
                 rooms = rl.rooms.get().execute_query()
                 for room in rooms:
-                    print(f"    ↳ {room.display_name:40s}  {room.email_address or ''}  ({room.capacity or '?'} seats)")
+                    print(f"  {room.display_name}  {room.email_address}  (capacity: {room.capacity})")
             except Exception:
                 pass
-    else:
-        print("(No room lists found — room list management may need Place.Read.All)")
-
-    # -- Step 2: find meeting times for next week --
-    now = datetime.now(timezone.utc)
-    start_time = now + timedelta(days=1)
-    end_time = now + timedelta(days=7)
 
-    # Collect room email addresses if available
-    attendee_smtp = ["meganb@contoso.onmicrosoft.com"]
+    attendees = ["meganb@contoso.onmicrosoft.com"]
     if room_lists:
-        for rl in room_lists[:1]:  # first room list
-            try:
-                rooms = rl.rooms.get().execute_query()
-                attendee_smtp.extend(r.email_address for r in rooms[:2] if r.email_address)
-            except Exception:
-                pass
-
-    print(f"\nFinding meeting times for: {', '.join(attendee_smtp)}")
-    print(f"  Window: {start_time.strftime('%Y-%m-%d %H:%M')} — {end_time.strftime('%Y-%m-%d %H:%M')}")
-
-    suggestions = client.me.find_meeting_times(
-        attendees=attendee_smtp,
-        meeting_duration=timedelta(hours=1),
-        max_candidates=5,
+        try:
+            rooms = room_lists[0].rooms.get().execute_query()
+            attendees.extend(r.email_address for r in rooms[:2] if r.email_address)
+        except Exception:
+            pass
+
+    result = client.me.find_meeting_times(
+        attendees=attendees, meeting_duration=timedelta(hours=1), max_candidates=5
     ).execute_query()
-
-    if suggestions and hasattr(suggestions, "value") and suggestions.value:
-        print(f"\nSuggested times ({len(suggestions.value)} candidate(s)):\n")
-        # The value is a MeetingTimeSuggestionsResult
-        result = suggestions.value
-        if hasattr(result, "meeting_time_suggestions") and result.meeting_time_suggestions:
-            for s in result.meeting_time_suggestions:
-                slot = s.meeting_time_slot
-                print(
-                    f"  {slot.start.strftime('%Y-%m-%d %H:%M')} — "
-                    f"{slot.end.strftime('%H:%M')}  (confidence: {s.confidence})"
-                )
-                if hasattr(s, "locations") and s.locations:
-                    for loc in s.locations:
-                        print(f"    Location: {loc.display_name}")
-        else:
-            print("  (no detailed suggestions — check permissions)")
-    else:
-        print("  No meeting suggestions returned.")
+    if result and result.value and result.value.meeting_time_suggestions:
+        for s in result.value.meeting_time_suggestions:
+            slot = s.meeting_time_slot
+            print(f"  {slot.start} — {slot.end}  (confidence: {s.confidence})")
 
 
 if __name__ == "__main__":

examples/outlook/messages/mail_tips.py

@@ -21,10 +21,10 @@
 
 client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
-tips = client.me.get_mail_tips([test_user_principal_name]).execute_query()
-for tip in tips.value or []:
-    print(f"Recipient: {tip.email_address.address}")
-    print(f"  Auto-replies: {tip.automatic_replies.message if tip.automatic_replies else 'none'}")
+result = client.me.get_mail_tips([test_user_principal_name]).execute_query()
+for tip in result.value:
+    print(f"Recipient: {tip.emailAddress}")
+    print(f"  Auto-replies: {tip.automaticReplies.message}")
     print(f"  Out of office: {tip.out_of_office}")
     print(f"  Mailbox full: {tip.mailbox_full}")
     print(f"  Max message size: {tip.max_message_size}")

examples/outlook/messages/mailbox_settings.py

@@ -18,24 +18,17 @@
 client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 
 # Read current mailbox settings
-settings = client.me.mailbox_settings.get().execute_query()
-print(f"Current automatic replies: {settings.automatic_replies_status}")
-
-# Enable scheduled automatic replies
-settings.set_property(
-    "automaticRepliesSetting",
-    {
-        "status": "scheduled",
-        "scheduledStartDateTime": {
-            "dateTime": (datetime.utcnow() + timedelta(hours=1)).isoformat(),
-            "timeZone": "UTC",
-        },
-        "scheduledEndDateTime": {
-            "dateTime": (datetime.utcnow() + timedelta(days=7)).isoformat(),
-            "timeZone": "UTC",
-        },
-        "internalReplyMessage": "I'm out of the office this week.",
-        "externalReplyMessage": "I'm out of the office. Please contact my manager.",
-    },
-).update().execute_query()
+me = client.me.select(["MailboxSettings"]).get().execute_query()
+print(f"Current automatic replies: {me.mailbox_settings.automaticRepliesSetting}")
+
+start = datetime.now()
+end = start + timedelta(days=5)
+me.enable_automatic_replies_setting(
+    status="scheduled",
+    scheduled_start_datetime=start,
+    scheduled_end_datetime=end,
+    internal_reply_message="I'm out of the office this week.",
+    external_reply_message="I'm out of the office. Please contact my manager.",
+).execute_query()
+
 print("Automatic replies enabled")

examples/outlook/shared_mailboxes/report.py

@@ -1,11 +1,7 @@
 """
-Shared mailboxes: list, check quotas, and find without owners.
+Shared mailboxes: list shared mailboxes in the tenant.
 
-Track shared mailboxes for licensing and governance.
-
-Requires delegated permission ``User.Read.All``.
-
-https://learn.microsoft.com/en-us/graph/api/user-list
+Requires delegated permission User.Read.All.
 """
 
 from office365.graph_client import GraphClient
@@ -14,8 +10,8 @@
 client = GraphClient(tenant=test_tenant).with_client_secret(test_client_id, test_client_secret)
 
 shared = (
-    client.users.filter("userType eq 'member' and userPrincipalName startsWith 'shared'").top(10).get().execute_query()
+    client.users.filter("userType eq 'Member' and startswith(userPrincipalName, 'shared')").top(10).get().execute_query()
 )
-print(f"Shared mailboxes found: {len(shared)}")
+print(f"Shared mailboxes: {len(shared)}")
 for m in shared:
-    print(f"  {m.display_name:30s}  {m.user_principal_name}  ({m.user_type or '?'})")
+    print(f"  {m.user_principal_name}")

examples/teams/call_records.py

@@ -15,8 +15,7 @@ def main():
     print(f"Call records: {len(records)}\n")
 
     for r in records:
-        org = r.organizer.user.user_principal_name if r.organizer and r.organizer.user else "?"
-        print(f"  {r.start_date_time}  {r.type_.name}  organizer={org}")
+        print(f"  {r.start_date_time}  {r.type_.name}  organizer={r.organizer.user}")
 
     if records:
         print()

examples/teams/tags/create_and_assign.py

@@ -30,7 +30,8 @@ def main():
 
     if member_ids:
         tag = team.tags.add(
-            displayName=TAG_NAME, description=TAG_DESCRIPTION,
+            displayName=TAG_NAME,
+            description=TAG_DESCRIPTION,
             members=[{"userId": uid} for uid in member_ids],
         ).execute_query()
         print(f"Tag created: {tag.display_name}  ({len(member_ids)} members)")

generator/.checkpoints/SharePoint.xml.json

@@ -4,23 +4,17 @@
 
 from office365.outlook.calendar.email_address import EmailAddress
 from office365.outlook.mail.automaticreplies.mailtips import AutomaticRepliesMailTips
+from office365.outlook.mail.recipient import Recipient
+from office365.outlook.mail.recipientscopetype import RecipientScopeType
 from office365.outlook.mail.tips.error import MailTipsError
 from office365.runtime.client_value import ClientValue
+from office365.runtime.client_value_collection import ClientValueCollection
 
 
 @dataclass
 class MailTips(ClientValue):
     """Informative messages about a recipient, displayed to users while they're composing a message.
     For example, an out-of-office message as an automatic reply for a message recipient.
-
-    Fields:
-        automaticReplies: Mail tips for automatic reply if set up by the recipient.
-        customMailTip: A custom mail tip set on the recipient's mailbox.
-        deliveryRestricted: Whether the recipient is delivery restricted.
-        emailAddress: Email address of the recipient.
-        error: Error raised when an error occurs during mail tips retrieval.
-        externalMemberCount: Number of external members if the recipient is a distribution list.
-        isModerated: Whether sending messages to the recipient requires approval.
     """
 
     automaticReplies: AutomaticRepliesMailTips = field(default_factory=AutomaticRepliesMailTips)
@@ -30,6 +24,13 @@ class MailTips(ClientValue):
     error: MailTipsError = field(default_factory=MailTipsError)
     externalMemberCount: int | None = None
     isModerated: bool | None = None
+    mailboxFull: bool | None = None
+    maxMessageSize: int | None = None
+    recipientScope: RecipientScopeType | None = None
+    recipientSuggestions: ClientValueCollection[Recipient] = field(
+        default_factory=lambda: ClientValueCollection(Recipient)
+    )
+    totalMemberCount: int | None = None
 
     @property
     def entity_type_name(self) -> str:

office365/outlook/mail/tips/tips.py

@@ -0,0 +1,13 @@
+from __future__ import annotations
+
+from office365.runtime.client_value import ClientValue
+
+
+class FieldInsertionItem(ClientValue):
+    Content: str | None = None
+    DataType: str | None = None
+    Name: str | None = None
+
+    @property
+    def entity_type_name(self) -> str:
+        return "Microsoft.SharePoint.Agreements.Models.FieldInsertionItem"