Merge to beta

[shivampkumar]

Why?

What?

See Also

---

Mirrored from stripe/stripe-java#2223 by mbroshi-stripe for the VibeOps live demo. Real PR, real diff, reviewed by the same pipeline our customers run.

[vibeops-ai]

✅ VibeOps Review — This PR adds Stripe-Notice header logging functionality with proper test coverage and documentation improvements.

🟢 Auto-approval eligible · L2 CORRECTNESS · 70% confidence

Suggestions (1)

Consider adding rawRequest() to Stripe-Notice logging for consistency
src/main/java/com/stripe/net/LiveStripeResponseGetter.java:246

The agent finding identified that rawRequest() method doesn't call maybeEmitStripeNotice() while request() and requestStream() do. While this is pre-existing and not a blocker, adding the call after line 255 would provide consistent notice logging across all HTTP methods.

📎 Cross-feature parity: request() at line 157 and requestStream() at line 202 both call maybeEmitStripeNotice after receiving a response; rawRequest() at line 246 does not, making the three sibling methods inconsistent.
🔗 Backed by: multi-agent agreement · agent reasoning

What's good

• Excellent test coverage with both positive and negative test cases for the Stripe-Notice header functionality, including proper logger setup and teardown.
• Clean implementation of the maybeEmitStripeNotice method using Optional.ifPresent() for elegant null-safe header processing.

Context

• This PR implements Stripe-Notice header logging to warn about API deprecations and other notices from Stripe's servers.
• Dropped: Pre-existing rawRequest inconsistency — while the agent correctly identified missing maybeEmitStripeNotice in rawRequest(), this is pre-existing code not introduced by this PR.

Dropped 1 finding: rawRequest missing maybeEmitStripeNotice — this is pre-existing code, not introduced by this PR's changes.

---

Reviewed by VibeOps

[vibeops-ai]

src/main/java/com/stripe/net/LiveStripeResponseGetter.java:246

🟡 Suggestion · The agent finding identified that rawRequest() method doesn't call maybeEmitStripeNotice() while request() and requestStream() do. While this is pre-existing and not a blocker, adding the call after line 255 would provide consistent notice logging across all HTTP methods.

🔗 Backed by: multi-agent agreement · agent reasoning

📌 Source: Cross-feature parity: request() at line 157 and requestStream() at line 202 both call maybeEmitStripeNotice after receiving a response; rawRequest() at line 246 does not, making the three sibling methods inconsistent.

Was this helpful? React with 👍 or 👎 to help VibeOps learn.