🪄 PyOB: Automated Lint & Format Fixes

Author: vicsanity623

src/pyob/entrance_mixins.py

@@ -1,5 +1,4 @@
 import difflib
-import json
 import logging
 import os
 import shutil
@@ -9,11 +8,13 @@
 
 logger = logging.getLogger(__name__)
 
+
 class EntranceMixin:
     """
     Mixin providing core iteration logic.
     Attributes are declared here to satisfy strict Mypy checks.
     """
+
     target_dir: str
     pyob_dir: str
     ENGINE_FILES: list[str]
@@ -32,28 +33,42 @@ class EntranceMixin:
 
     def pick_target_file(self) -> str:
         return ""
+
     def _read_file(self, path: str) -> str:
         return ""
+
     def _extract_path_from_llm_response(self, text: str) -> str:
         return ""
-    def get_valid_llm_response(self, p: str, v: Callable[[str], bool], context: str) -> str:
+
+    def get_valid_llm_response(
+        self, p: str, v: Callable[[str], bool], context: str
+    ) -> str:
         return ""
+
     def update_analysis_for_single_file(self, abs_p: str, rel_p: str):
         pass
+
     def update_ledger_for_file(self, rel_p: str, code: str):
         pass
+
     def detect_symbolic_ripples(self, o: str, n: str, p: str) -> list[str]:
         return []
+
     def _run_final_verification_and_heal(self, b: dict) -> bool:
         return False
+
     def handle_git_librarian(self, p: str, i: int):
         pass
+
     def append_to_history(self, p: str, o: str, n: str):
         pass
+
     def wrap_up_evolution_session(self):
         pass
+
     def generate_pr_summary(self, rel_path: str, diff_text: str) -> dict:
         return {}
+
     def execute_targeted_iteration(self, iteration: int):
         """Orchestrates a single targeted evolution step."""
         backup_state = self.llm_engine.backup_workspace()
@@ -62,7 +77,9 @@ def execute_targeted_iteration(self, iteration: int):
         if self.cascade_queue:
             target_rel_path = self.cascade_queue.pop(0)
             target_diff = self.cascade_diffs.get(target_rel_path, "")
-            logger.warning(f"SYMBOLIC CASCADE: Targeting impacted file: {target_rel_path}")
+            logger.warning(
+                f"SYMBOLIC CASCADE: Targeting impacted file: {target_rel_path}"
+            )
             is_cascade = True
         else:
             target_rel_path = self.pick_target_file()
@@ -99,17 +116,18 @@ def execute_targeted_iteration(self, iteration: int):
                 old_content = f.read()
 
         from pyob.targeted_reviewer import TargetedReviewer
+
         reviewer = TargetedReviewer(self.target_dir, target_abs_path)
         reviewer.session_context = self.llm_engine.session_context[:]
-        if hasattr(self, 'key_cooldowns'):
+        if hasattr(self, "key_cooldowns"):
             reviewer.key_cooldowns = self.key_cooldowns
-        if hasattr(self, 'session_pr_count'):
+        if hasattr(self, "session_pr_count"):
             reviewer.session_pr_count = self.session_pr_count
 
         reviewer.run_pipeline(iteration)
 
         self.llm_engine.session_context = reviewer.session_context[:]
-        if hasattr(reviewer, 'session_pr_count'):
+        if hasattr(reviewer, "session_pr_count"):
             self.session_pr_count = reviewer.session_pr_count
 
         new_content = ""
@@ -124,8 +142,15 @@ def execute_targeted_iteration(self, iteration: int):
         if old_content != new_content:
             logger.info(f"Edit successful. Verifying {target_rel_path}...")
             self.append_to_history(target_rel_path, old_content, new_content)
-            current_diff = "".join(difflib.unified_diff(old_content.splitlines(keepends=True), new_content.splitlines(keepends=True)))
-            ripples = self.detect_symbolic_ripples(old_content, new_content, target_rel_path)
+            current_diff = "".join(
+                difflib.unified_diff(
+                    old_content.splitlines(keepends=True),
+                    new_content.splitlines(keepends=True),
+                )
+            )
+            ripples = self.detect_symbolic_ripples(
+                old_content, new_content, target_rel_path
+            )
             if ripples:
                 for r in ripples:
                     if r not in self.cascade_queue:
@@ -140,6 +165,10 @@ def execute_targeted_iteration(self, iteration: int):
                     self.self_evolved_flag = True
 
             # --- THE FINAL WRAP-UP GATE ---
-            if getattr(self, "session_pr_count", 0) >= 8 and not getattr(self, "cascade_queue", []):
-                logger.info(f"🏆 MISSION ACCOMPLISHED: {self.session_pr_count} PRs achieved.")
+            if getattr(self, "session_pr_count", 0) >= 8 and not getattr(
+                self, "cascade_queue", []
+            ):
+                logger.info(
+                    f"🏆 MISSION ACCOMPLISHED: {self.session_pr_count} PRs achieved."
+                )
                 self.wrap_up_evolution_session()

src/pyob/prompts_and_memory.py

@@ -31,7 +31,7 @@ def _ensure_prompt_files(self) -> None:
         templates = {
             "UM.md": "You are the PyOB Memory Manager. Your job is to update MEMORY.md.\n\n### Current Memory:\n{current_memory}\n\n### Recent Actions:\n{session_summary}\n\n### INSTRUCTIONS:\n1. Update the memory with the Recent Actions.\n2. TRANSACTIONAL RECORDING: Only record changes as 'Implemented' if the actions specifically state 'SUCCESSFUL CHANGE'. If you see 'CRITICAL: FAILED' or 'ROLLED BACK', record this as a 'Failed Attempt' with the reason, so the engine knows to try a different approach next time.\n3. BREVITY: Keep the ENTIRE document under 200 words. Be ruthless. Delete old, irrelevant details.\n4. FORMAT: Keep lists strictly to bullet points. No long paragraphs.\n5. **HUMAN DIRECTIVES**: If the current memory contains a section titled HUMAN DIRECTIVES, you are strictly FORBIDDEN from deleting or altering it. Prepend all new session summaries BELOW that section.\n6. Respond EXCLUSIVELY with the raw markdown for MEMORY.md. Do not use ```markdown fences or <THOUGHT> blocks.\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.",
             "RM.md": "You are the PYOB Memory Manager. The current MEMORY.md is too bloated and is breaking the AI context window.\n\n### Bloated Memory:\n{current_memory}\n\n### INSTRUCTIONS:\n1. AGGRESSIVELY COMPRESS this memory. \n2. Delete duplicate information, repetitive logs, and obvious statements.\n3. Keep ONLY the core architectural rules and crucial file dependencies.\n4. The final output MUST BE UNDER 150 WORDS.\n5. Respond EXCLUSIVELY with the raw markdown. No fences, no thoughts.\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.",
-            "PP.md": "You are an elite PYOB Software Engineer. Analyze the code for bugs or architectural gaps.\n\n{memory_section}{ruff_section}{mypy_section}{custom_issues_section}### Source Code:\n```{lang_tag}\n{content}\n```\n\n### CRITICAL RULES:\n1. **ITERATION BUDGET**: \n   - IF iteration < 5: Focus ONLY on bug fixes, linting, and minor performance tweaks. Do NOT create new files, move classes, or extract logic. \n   - IF iteration >= 5: You may propose architectural refactors, file extractions, and logic movement.\n2. **SURGICAL FIXES**: Every <SEARCH> block must be exactly 2-5 lines. Only provide ONE <EDIT> block per response.\n3. **NO HALLUCINATIONS**: Do not invent bugs. If the code is functional, state 'The code looks good.'\n4. **ARCHITECTURAL BLOAT**: Only flag bloat for future planning until iteration 5.\n5. **MISSING IMPORTS**: If you use a new module/type, you MUST add an <EDIT> block to import it at the top.\n6. **INDENTATION IS SYNTAX**: Your <REPLACE> blocks must have perfect, absolute indentation.\n7. **DEFEATING MYPY**: If fixing a `[union-attr]` error, use `assert variable is not None` or `# type: ignore`.\n8. **IMPORT PATHS (MANDATORY)**: Never use the prefix `src.` in any import statement. The root of the package is `pyob`. (Example: Use `from pyob.core_utils import ...`, NOT `from src.pyob.core_utils import ...`).\n9. **TYPE HINTS (CRITICAL)**: Never use the `|` operator with quoted class names (Forward References). Use `Any` for objects that create circular dependencies.\n10. **ATOMIC REFACTORING**: If you are beyond iteration 5 and need to move logic, use a 3-step process: A) Add new file/imports. B) Update call sites. C) Remove old code in a subsequent turn.\n11. **NO SCAFFOLDING (CRITICAL)**: Never include bot-specific text, logs, or status tags (like \"APPROVED\" or \"LIBRARIAN\") inside the code blocks. Your output must be 100% valid code for the target language.\n\n### HOW TO RESPOND (CHOOSE ONE):\n\n**SCENARIO A: Code has bugs/bloat and needs edits:**\n<THOUGHT>\nSummary: ...\nEvaluation: [Address bloat here if flagged]\nImports Required: ...\nAction: I will fix X by doing Y.\n</THOUGHT>\n<EDIT>\n<SEARCH>\nExact lines to replace (2-5 lines max)\n</SEARCH>\n<REPLACE>\nNew lines\n</REPLACE>\n</EDIT>\n\n**SCENARIO B: Code is perfect. NO EDITS NEEDED:**\n<THOUGHT>\nSummary: ...\nEvaluation: ...\nAction: The code looks good. No fixes needed.\n</THOUGHT>\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.",
+            "PP.md": 'You are an elite PYOB Software Engineer. Analyze the code for bugs or architectural gaps.\n\n{memory_section}{ruff_section}{mypy_section}{custom_issues_section}### Source Code:\n```{lang_tag}\n{content}\n```\n\n### CRITICAL RULES:\n1. **ITERATION BUDGET**: \n   - IF iteration < 5: Focus ONLY on bug fixes, linting, and minor performance tweaks. Do NOT create new files, move classes, or extract logic. \n   - IF iteration >= 5: You may propose architectural refactors, file extractions, and logic movement.\n2. **SURGICAL FIXES**: Every <SEARCH> block must be exactly 2-5 lines. Only provide ONE <EDIT> block per response.\n3. **NO HALLUCINATIONS**: Do not invent bugs. If the code is functional, state \'The code looks good.\'\n4. **ARCHITECTURAL BLOAT**: Only flag bloat for future planning until iteration 5.\n5. **MISSING IMPORTS**: If you use a new module/type, you MUST add an <EDIT> block to import it at the top.\n6. **INDENTATION IS SYNTAX**: Your <REPLACE> blocks must have perfect, absolute indentation.\n7. **DEFEATING MYPY**: If fixing a `[union-attr]` error, use `assert variable is not None` or `# type: ignore`.\n8. **IMPORT PATHS (MANDATORY)**: Never use the prefix `src.` in any import statement. The root of the package is `pyob`. (Example: Use `from pyob.core_utils import ...`, NOT `from src.pyob.core_utils import ...`).\n9. **TYPE HINTS (CRITICAL)**: Never use the `|` operator with quoted class names (Forward References). Use `Any` for objects that create circular dependencies.\n10. **ATOMIC REFACTORING**: If you are beyond iteration 5 and need to move logic, use a 3-step process: A) Add new file/imports. B) Update call sites. C) Remove old code in a subsequent turn.\n11. **NO SCAFFOLDING (CRITICAL)**: Never include bot-specific text, logs, or status tags (like "APPROVED" or "LIBRARIAN") inside the code blocks. Your output must be 100% valid code for the target language.\n\n### HOW TO RESPOND (CHOOSE ONE):\n\n**SCENARIO A: Code has bugs/bloat and needs edits:**\n<THOUGHT>\nSummary: ...\nEvaluation: [Address bloat here if flagged]\nImports Required: ...\nAction: I will fix X by doing Y.\n</THOUGHT>\n<EDIT>\n<SEARCH>\nExact lines to replace (2-5 lines max)\n</SEARCH>\n<REPLACE>\nNew lines\n</REPLACE>\n</EDIT>\n\n**SCENARIO B: Code is perfect. NO EDITS NEEDED:**\n<THOUGHT>\nSummary: ...\nEvaluation: ...\nAction: The code looks good. No fixes needed.\n</THOUGHT>\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.',
             "ALF.md": "You are an elite developer fixing syntax errors.\nThe file `{rel_path}` failed validation with these exact errors:\n{err_text}\n\n### Current Code:\n```\n{code}\n```\n\n### Instructions:\n1. Fix the syntax errors (like stray brackets, unexpected tokens, or indentation) using surgical XML edits.\n2. Respond EXCLUSIVELY with a <THOUGHT> block followed by ONE OR MORE <EDIT> blocks.\n3. Ensure your edits perfectly align with the surrounding brackets.\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.",
             "FRE.md": "You are an elite PYOB developer fixing runtime crashes.\n{memory_section}The application crashed during a test run.\n\n### Crash Logs & Traceback:\n{logs}\n\nThe traceback indicates the error occurred in `{rel_path}`.\n\n### Current Code of `{rel_path}`:\n```python\n{code}\n```\n\n### Instructions:\n1. Identify the EXACT root cause of the crash.\n2. Fix the error using surgical XML edits.\n3. Respond EXCLUSIVELY with a <THOUGHT> block followed by ONE OR MORE <EDIT> blocks.\n\n### REQUIRED XML FORMAT:\n<THOUGHT>\nExplanation of root cause...\nImports Needed: [List new imports required or 'None']\n</THOUGHT>\n<EDIT>\n<SEARCH>\nExact lines to replace\n</SEARCH>\n<REPLACE>\nNew replacement lines\n</REPLACE>\n</EDIT>",
             "PF.md": "You are the PYOB Product Architect. Review the source code and suggest ONE highly useful, INTERACTIVE feature.\n\n{memory_section}### Source Code:\n```{lang_tag}\n{content}\n```\n\n### CRITICAL RULES:\n1. Suggest an INTERACTIVE feature (UI elements, buttons, menus).\n2. **ARCHITECTURAL SPLIT (MANDATORY)**: If the source code is over 800 lines, you ARE NOT ALLOWED to propose a new feature. You MUST propose an 'Architectural Split'. Identify a logical module (like a Mixin) to move to a NEW file.\n3. **SINGLE FILE LIMIT**: If you are proposing an Architectural Split, you are ONLY allowed to create ONE new file per iteration. Do not attempt to split multiple modules at once. Focus on the largest logical block first.\n4. **NEW FILE FORMAT**: If proposing a split, your <SNIPPET> block MUST use this format: <CREATE_FILE path=\"new_filename.py\">[Full Code for New File]</CREATE_FILE>. Your <THOUGHT> must then explain how to update the original file to import this new module.\n5. MULTI-FILE ORCHESTRATION: Explicitly list filenames of other files that will need updates in your <THOUGHT>.\n6. The <SNIPPET> block MUST contain ONLY the new logic or the <CREATE_FILE> block.\n\n### REQUIRED XML FORMAT:\n<THOUGHT>\n...\n</THOUGHT>\n<SNIPPET>\n# New logic OR <CREATE_FILE> tag here\n</SNIPPET>\n FINAL WARNING: Only output XML and code. If you add conversational text outside of <THOUGHT> or <EDIT>, the system will ROLLBACK.",