Refactor: Simplify XML replacement logic and remove redundant indentation handling#337
Merged
Merged
Conversation
Fix: Filter noise and refine regex in AST reference extraction
Refactor: Add type hints to CodeParser AST visitor methods
Fix: Suppress type checking errors for unix-specific imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
ApplyXMLMixinto use rawsearch_linesinstead of pre-stripped versions, ensuring more accurate matching._fix_replace_indentationmethod call during the replacement process.new_code_linesconstruction by directly injectingreplace_linesinstead of processing them through an intermediate indentation fix.Technical Impact
sline.strip() not in code_lines[i + j].strip()ensures that the search logic is more robust against whitespace variations while maintaining strict adherence to the provided search patterns.