Skip to content

Refactor: Add type hinting and explicit attribute declaration in TargetedReviewer #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pyob-bot wants to merge 1 commit into
base: pyob-evolution-v5-1781235964
Choose a base branch
from
Open

Refactor: Add type hinting and explicit attribute declaration in TargetedReviewer #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pyob/targeted_reviewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ class TargetedReviewer(AutoReviewer):
Automatically handles both absolute and relative path inputs for cross-platform stability.
"""

def __init__(self, target_dir: str, target_file: str):
def __init__(self, target_dir: str, target_file: str) -> None:
# Normalize the directory path
normalized_dir = os.path.normpath(target_dir)
normalized_dir: str = os.path.normpath(target_dir)
super().__init__(normalized_dir)

# Normalize the target file path to avoid cross-platform slash issues
normalized_file = os.path.normpath(target_file)
normalized_file: str = os.path.normpath(target_file)
self.forced_target_file: str

if os.path.isabs(normalized_file):
self.forced_target_file = os.path.relpath(normalized_file, self.target_dir)
Expand Down
Loading