Skip to content

Refactor: Improve type safety and readability in dynamic do_POST wrapper #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pyob-bot wants to merge 1 commit into
base: pyob-evolution-v8-1781236499
Choose a base branch
from
Open

Refactor: Improve type safety and readability in dynamic do_POST wrapper #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/pyob/entrance_mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ def _dynamic_do_POST_method(self: ObserverHandler) -> None:
# Capture existing do_POST if it exists to avoid breaking other APIs
original_do_POST = getattr(ObserverHandler, "do_POST", None)

def _dynamic_do_POST_wrapper(self: ObserverHandler) -> None:
if self.path == "/set_target":
_dynamic_do_POST_method(self)
def _dynamic_do_POST_wrapper(instance: ObserverHandler) -> None:
if instance.path == "/set_target":
_dynamic_do_POST_method(instance)
elif original_do_POST is not None:
original_do_POST(self)
original_do_POST(instance)
else:
self.send_error(404)
instance.send_error(404)

setattr(ObserverHandler, "do_POST", _dynamic_do_POST_wrapper)

Expand Down
Loading