feature: Allow Custom Modules to be configured with options#551
Open
Tiffel wants to merge 1 commit intovictools:mainfrom
Open
feature: Allow Custom Modules to be configured with options#551Tiffel wants to merge 1 commit intovictools:mainfrom
Tiffel wants to merge 1 commit intovictools:mainfrom
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Tiffel
changed the title
Member
|
HI @Tiffel Thank you for raising this, and I'm looking forward to your PR extending the existing |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a custom module to handle Jacksons @JSONVIEW Annotations (happy to open source this as soon it's polished). I had to hardcode the parameter, because custom modules are not configurable at the moment.
This is my attempt to improve on that limitation