Rename JacksonModule to JacksonSchemaModule to avoid clashing with the JacksonModule from jackson-databind#561
Merged
CarstenWickner merged 1 commit intoFeb 7, 2026
Conversation
…e JacksonModule from jackson-databind
Closed
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Failed
(1 file with Complex Conditional)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| JacksonSchemaModule.java | 1 advisory rule | 9.69 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| JacksonModule.java | 9.69 → 10.00 | Complex Conditional |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
| if (annotation != null) { | ||
| String nameOverride = annotation.value(); | ||
| // check for invalid overrides | ||
| if (nameOverride != null && !nameOverride.isEmpty() && !nameOverride.equals(member.getDeclaredName())) { |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
getPropertyNameOverrideBasedOnJsonPropertyAnnotation has 1 complex conditionals with 2 branches, threshold = 2
CarstenWickner
merged commit a48dc1d
into
victools:jackson-module-rename
8 of 9 checks passed
CarstenWickner
added a commit
that referenced
this pull request
Feb 7, 2026
* feat: Rename JacksonModule to JacksonSchemaModule to avoid clashing with the JacksonModule from jackson-databind (#561) --------- Co-authored-by: Filip Hrisafov <filip.hrisafov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in relation to the comment from @sdeleuze in #553 (comment). @CarstenWickner if this is not something that you would like to include, then please reject the PR