Skip to content

Commit 12a946c

Browse files
committed
Log ManagedMediaSource buffer removal
1 parent 9b43240 commit 12a946c

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/controller/base-stream-controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import {
4343
} from '../utils/level-helper';
4444
import { estimatedAudioBitrate } from '../utils/mediacapabilities-helper';
4545
import { appendUint8Array } from '../utils/mp4-tools';
46-
import TimeRanges from '../utils/time-ranges';
46+
import { timeRangesToString } from '../utils/time-ranges';
4747
import type { FragmentTracker } from './fragment-tracker';
4848
import type { HlsConfig } from '../config';
4949
import type TransmuxerInterface from '../demux/transmuxer-interface';
@@ -826,7 +826,7 @@ export default class BaseStreamController
826826
part ? ' part: ' + part.index : ''
827827
} of ${this.fragInfo(frag, false, part)} > buffer:${
828828
media
829-
? TimeRanges.toString(BufferHelper.getBuffered(media))
829+
? timeRangesToString(BufferHelper.getBuffered(media))
830830
: '(detached)'
831831
})`,
832832
);

src/controller/buffer-controller.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
isManagedMediaSource,
2424
} from '../utils/mediasource-helper';
2525
import { stringify } from '../utils/safe-json-stringify';
26+
import { timeRangesToString } from '../utils/time-ranges';
2627
import type { FragmentTracker } from './fragment-tracker';
2728
import type { HlsConfig } from '../config';
2829
import type Hls from '../hls';
@@ -1687,6 +1688,9 @@ transfer tracks: ${stringify(transferredTracks, (key, value) => (key === 'initSe
16871688
// If media was ejected check for a change. Added ranges are redundant with changes on 'updateend' event.
16881689
const removedRanges = event.removedRanges;
16891690
if (removedRanges?.length) {
1691+
this.log(
1692+
`${type} buffer removed ${timeRangesToString(removedRanges)}`,
1693+
);
16901694
this.hls.trigger(Events.BUFFER_FLUSHED, {
16911695
type: type,
16921696
});

src/utils/time-ranges.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,12 @@
22
* TimeRanges to string helper
33
*/
44

5-
const TimeRanges = {
6-
toString: function (r: TimeRanges) {
7-
let log = '';
8-
const len = r.length;
9-
for (let i = 0; i < len; i++) {
10-
log += `[${r.start(i).toFixed(3)}-${r.end(i).toFixed(3)}]`;
11-
}
5+
export function timeRangesToString(r: TimeRanges) {
6+
let log = '';
7+
const len = r.length;
8+
for (let i = 0; i < len; i++) {
9+
log += `[${r.start(i).toFixed(3)}-${r.end(i).toFixed(3)}]`;
10+
}
1211

13-
return log;
14-
},
15-
};
16-
17-
export default TimeRanges;
12+
return log;
13+
}

0 commit comments

Comments
 (0)