Skip to content

Commit b2f8e06

Browse files
committed
move flaky test asset to not run in FF
1 parent 4331ee5 commit b2f8e06

File tree

1 file changed

+27
-26
lines changed

1 file changed

+27
-26
lines changed

test/playback.test.js

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -250,32 +250,6 @@ QUnit.test('Live DASH', function(assert) {
250250
player.play();
251251
});
252252

253-
QUnit.test('Multiperiod dash works and can end', function(assert) {
254-
const done = assert.async();
255-
256-
assert.expect(2);
257-
const player = this.player;
258-
259-
playFor(player, 2, function() {
260-
assert.ok(true, 'played for at least two seconds');
261-
assert.equal(player.error(), null, 'has no player errors');
262-
263-
player.one('ended', () => {
264-
assert.ok(true, 'triggered ended event');
265-
done();
266-
});
267-
268-
player.currentTime(player.duration() - 0.5);
269-
270-
done();
271-
});
272-
273-
player.src({
274-
src: 'https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod.mpd',
275-
type: 'application/dash+xml'
276-
});
277-
});
278-
279253
// These videos don't work on firefox consistenly. Seems like
280254
// firefox has lower performance or more aggressive throttling than chrome
281255
// which causes a variety of issues.
@@ -424,6 +398,33 @@ if (!videojs.browser.IS_FIREFOX) {
424398
});
425399
});
426400

401+
// Firefox 64 cannot retrieve the asset, reporting a CORS issue.
402+
QUnit.test('Multiperiod dash works and can end', function(assert) {
403+
const done = assert.async();
404+
405+
assert.expect(2);
406+
const player = this.player;
407+
408+
playFor(player, 2, function() {
409+
assert.ok(true, 'played for at least two seconds');
410+
assert.equal(player.error(), null, 'has no player errors');
411+
412+
player.one('ended', () => {
413+
assert.ok(true, 'triggered ended event');
414+
done();
415+
});
416+
417+
player.currentTime(player.duration() - 0.5);
418+
419+
done();
420+
});
421+
422+
player.src({
423+
src: 'https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod.mpd',
424+
type: 'application/dash+xml'
425+
});
426+
});
427+
427428
// TODO: why does this make the next test
428429
// throw an "The operation was aborted." on firefox
429430
QUnit.test('loops', function(assert) {

0 commit comments

Comments
 (0)