Commit 09b3376
docs(site): tighten HTML examples in build-your-own-component guide
- Drop unused `static tagName` from the full skip-intro example (the
guide registers via `customElements.define()` directly, so the field
is dead code from a userland perspective).
- Forward `changed: PropertyValues` to `super.update()` in both the
intro skeleton and the full example, matching first-party convention
and the actual `ReactiveElement` signature. `PropertyValues` now
imports from `@videojs/html` (re-exported via #1472).
- Trim the "Place your component" skeleton — drop comments and
`customElements.define` line — so it's a minimal anchor for what's
required, leaving the full example as the first complete class.
Addresses review feedback on #1008.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 54837b7 commit 09b3376
1 file changed
Lines changed: 13 additions & 13 deletions
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | | - | |
135 | 134 | | |
136 | | - | |
137 | 135 | | |
138 | 136 | | |
139 | | - | |
140 | | - | |
141 | | - | |
| 137 | + | |
| 138 | + | |
142 | 139 | | |
143 | 140 | | |
144 | 141 | | |
145 | | - | |
146 | | - | |
147 | 142 | | |
148 | 143 | | |
149 | 144 | | |
| |||
221 | 216 | | |
222 | 217 | | |
223 | 218 | | |
224 | | - | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
225 | 227 | | |
226 | 228 | | |
227 | | - | |
228 | | - | |
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
255 | | - | |
| 254 | + | |
| 255 | + | |
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| |||
0 commit comments