feat(packages): add built-in locale packs with v8 parity by sampotts · Pull Request #1566 · videojs/v10

sampotts · 2026-05-19T07:26:01Z

Summary

Add 50+ built-in locale packs in @videojs/core (default export per @videojs/core/i18n/locales/*), with pt/zh v8 aliases and pt-BR/pt-PT, zh-CN/zh-TW splits.
Expose framework entry points at @videojs/html/i18n and @videojs/react/i18n (locales/*, all) so apps register packs without importing core directly.
Wire sandbox locale picker and completeness tests; ignore accidental src declaration emit under i18n paths.

Closes #1368

Stacked on #1367 (feat/i18n-ui-elements).

Test plan

pnpm -F @videojs/core test src/core/i18n/tests
pnpm -F @videojs/core build && pnpm -F @videojs/html build && pnpm typecheck
Sandbox: switch locale on HTML and React video demos; confirm control labels update
import es from '@videojs/html/i18n/locales/es' + registerI18n('es', es) works

Made with Cursor

Note

Medium Risk
Medium risk due to introducing many new i18n exports/entrypoints and build config changes across core, html, and react, which could affect package resolution and bundle size. Sandbox wiring is low risk but depends on new postMessage/query-param plumbing for locale.

Overview
Adds built-in i18n locale packs (50+ translations) to @videojs/core, including new @videojs/*/i18n/all entrypoints, v8 alias tags (pt, zh), and pt-BR/pt-PT, zh-CN/zh-TW splits.

Updates package exports and build configs (tsdown.config.ts) for core, html, and react to ship i18n/all and per-locale modules, and refactors BuiltInLocale typing to derive from a single BUILT_IN_LOCALES list.

Wires the sandbox to support runtime language switching via a new locale query param and postMessage channel, adds a language picker in the settings menu for video presets, and updates HTML/React templates to apply the selected locale to their i18n providers.

^{Reviewed by Cursor Bugbot for commit 06c0f4f. Bugbot is set up for automated code reviews on this repo. Configure here.}

vercel · 2026-05-19T07:26:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
v10-sandbox	Error		May 23, 2026 1:32am

mister-ben · 2026-05-20T07:19:23Z

+  startCasting: 'Übertragung starten',
+  stopCasting: 'Übertragung beenden',


Suggested change

startCasting: 'Übertragung starten',

stopCasting: 'Übertragung beenden',

startCasting: 'Streamen',

stopCasting: 'Streamen beenden',

Chrome's UI used to use übertragen for casting, but settled on streamen a while back.

mister-ben · 2026-05-20T07:31:42Z

+  startCasting: 'Übertragung starten',
+  stopCasting: 'Übertragung beenden',
+  connectingCast: 'Verbinden',
+  seek: 'Status',


v8 has "Status" for "Progress", but this probably isn't right if the English is "seek". How and where is this used?

mister-ben · 2026-05-20T07:33:00Z

+  playingLive: 'Zur Live-Übertragung wechseln. Es wird aktuell live abgespielt.',
+  seekToLiveEdge: 'Zur Live-Übertragung wechseln. Aktuell wird es nicht live abgespielt.',


Suggested change

playingLive: 'Zur Live-Übertragung wechseln. Es wird aktuell live abgespielt.',

seekToLiveEdge: 'Zur Live-Übertragung wechseln. Aktuell wird es nicht live abgespielt.',

playingLive: 'Es wird live abgespielt.',

seekToLiveEdge: 'Zurück zur Liveübertragung.',

These always were more clunky than they needed to be in v8.

mister-ben · 2026-05-20T07:40:52Z

+  play: 'Wiedergabe',
+  pause: 'Pause',
+  replay: 'Erneut abspielen',
+  mute: 'Stumm schalten',


Suggested change

mute: 'Stumm schalten',

mute: 'Stummschalten',

Ship 50+ non-English locale modules in core (default export per pack), with framework entry points at @videojs/html/i18n and @videojs/react/i18n (locales/* and all). Includes pt-BR/pt-PT and zh-CN/zh-TW splits, pt/zh v8 aliases, locale completeness tests, dynamic tsdown entries, and sandbox locale picker wiring. Closes #1368 Co-authored-by: Cursor <cursoragent@cursor.com>

Fill in remaining built-in translations, restore per-locale timeSliderValueTextRange for screen readers, and drop redundant slider keys that do not vary by language. Co-authored-by: Cursor <cursoragent@cursor.com>

Satisfies ParametricTranslations so html/react i18n/all typechecks. Co-authored-by: Cursor <cursoragent@cursor.com>

src/ is gitignored; Vercel clones without it so dir-compare failed. Co-authored-by: Cursor <cursoragent@cursor.com>

Mirror-only setup is enough for CI and fresh clones; use reset/sync when src drifts from templates. Co-authored-by: Cursor <cursoragent@cursor.com>

Replace English PiP labels left in the ko locale pack. Co-authored-by: Cursor <cursoragent@cursor.com>

Locale pack aggregation lives in html and react; core does not ship this entry. Co-authored-by: Cursor <cursoragent@cursor.com>

Intl.DisplayNames maps the v8 `ba` tag to Bashkir; override it to Bosnian. Co-authored-by: Cursor <cursoragent@cursor.com>

Video.js v8 used ba for Bosnian, but BCP 47 assigns ba to Bashkir and bs to Bosnian. Use the correct tag so Intl labels and locale lookup work without sandbox overrides. Co-authored-by: Cursor <cursoragent@cursor.com>

Keep generic language tags in the locale union alongside regional packs. Co-authored-by: Cursor <cursoragent@cursor.com>

Move the aggregated locale map to @videojs/core/i18n/all and keep thin html/react entry points for existing import paths. Co-authored-by: Cursor <cursoragent@cursor.com>

Avoid a flash of English copy when the sandbox locale changes after mount. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 06c0f4f. Configure here.}

cursor · 2026-05-22T02:21:40Z

+  indicatorFullscreen: 'Plein écran',
+  indicatorExitFullscreen: 'Quitter le plein écran',
+  indicatorPictureInPicture: 'Image dans l’image',
+  indicatorExitPictureInPicture: 'Quitter l’image dans l’image',


French locale mixes apostrophe character encodings

Low Severity

The French locale uses two different apostrophe characters for the same text. Lines 15–16 use double-quoted strings (containing ASCII APOSTROPHE U+0027 for l'image), while lines 40–41 use single-quoted strings with Unicode RIGHT SINGLE QUOTATION MARK U+2019 for the identical phrase. Same inconsistency affects s'est on lines 50 and 52. French users see visually mismatched apostrophes across different UI contexts.

Additional Locations (2)

packages/core/src/core/i18n/locales/fr.ts#L49-L52

packages/core/src/core/i18n/locales/fr.ts#L14-L16

^{Reviewed by Cursor Bugbot for commit 06c0f4f. Configure here.}

sampotts · 2026-05-22T03:09:07Z

Consolidating i18n work into a single feature branch (feat/i18n) until the feature is complete. This stacked PR is closed; we will reopen as a fresh split review stack from feat/i18n when ready for review.

github-project-automation Bot added this to Video.js 10 Roadmap May 19, 2026

sampotts force-pushed the feat/i18n-ui-elements branch 3 times, most recently from 07f598b to 56466e2 Compare May 20, 2026 03:31

sampotts force-pushed the feat/i18n-locale-packs branch from 9f2dc4e to 63898ce Compare May 20, 2026 03:31

vercel Bot had a problem deploying to Preview May 20, 2026 03:31 Failure

vercel Bot had a problem deploying to Preview May 20, 2026 04:14 Failure

vercel Bot had a problem deploying to Preview May 20, 2026 04:17 Failure

vercel Bot deployed to Preview May 20, 2026 04:28 View deployment

vercel Bot deployed to Preview May 20, 2026 04:29 View deployment

vercel Bot deployed to Preview May 20, 2026 04:39 View deployment

sampotts force-pushed the feat/i18n-ui-elements branch from 56466e2 to aa63876 Compare May 20, 2026 05:25

sampotts force-pushed the feat/i18n-locale-packs branch from 395fc2f to 3f036bb Compare May 20, 2026 05:25

vercel Bot deployed to Preview May 20, 2026 05:26 View deployment

sampotts force-pushed the feat/i18n-ui-elements branch from aa63876 to eeb7263 Compare May 20, 2026 05:28

sampotts force-pushed the feat/i18n-locale-packs branch from 3f036bb to ff04df3 Compare May 20, 2026 05:29

vercel Bot deployed to Preview May 20, 2026 05:29 View deployment

sampotts force-pushed the feat/i18n-locale-packs branch from ff04df3 to 6401cdb Compare May 20, 2026 05:33

vercel Bot deployed to Preview May 20, 2026 05:33 View deployment

sampotts force-pushed the feat/i18n-ui-elements branch from 2946154 to a9ebb9f Compare May 20, 2026 05:49

sampotts force-pushed the feat/i18n-locale-packs branch from 6401cdb to 311a1a6 Compare May 20, 2026 05:49

vercel Bot deployed to Preview May 20, 2026 05:49 View deployment

sampotts force-pushed the feat/i18n-ui-elements branch from a9ebb9f to 1e9229b Compare May 20, 2026 06:02

sampotts force-pushed the feat/i18n-locale-packs branch from 311a1a6 to 470a768 Compare May 20, 2026 06:08

vercel Bot deployed to Preview May 20, 2026 06:09 View deployment

sampotts marked this pull request as ready for review May 20, 2026 06:16

sampotts requested review from luwes and mihar-22 May 20, 2026 06:23

mister-ben reviewed May 20, 2026

View reviewed changes

cursor Bot reviewed May 22, 2026

View reviewed changes

Comment thread apps/sandbox/templates/react-video/main.tsx

sampotts force-pushed the feat/i18n-ui-elements branch from 3fddf1d to b36a1b8 Compare May 22, 2026 02:02

sampotts force-pushed the feat/i18n-locale-packs branch from 77c5968 to 77d7fdf Compare May 22, 2026 02:02

vercel Bot deployed to Preview May 22, 2026 02:02 View deployment

sampotts force-pushed the feat/i18n-locale-packs branch from 77d7fdf to 2b57799 Compare May 22, 2026 02:08

sampotts force-pushed the feat/i18n-ui-elements branch from b36a1b8 to 3491def Compare May 22, 2026 02:08

vercel Bot deployed to Preview May 22, 2026 02:08 View deployment

sampotts force-pushed the feat/i18n-ui-elements branch from 3491def to dd4164e Compare May 22, 2026 02:10

sampotts force-pushed the feat/i18n-locale-packs branch from 2b57799 to 5cacef4 Compare May 22, 2026 02:10

vercel Bot deployed to Preview May 22, 2026 02:10 View deployment

sampotts and others added 12 commits May 22, 2026 12:12

feat(core): complete locale packs and localize time slider valuetext

5beb873

Fill in remaining built-in translations, restore per-locale timeSliderValueTextRange for screen readers, and drop redundant slider keys that do not vary by language. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(core): add {rate} to playbackRateAria in all locale packs

c1db5a2

Satisfies ParametricTranslations so html/react i18n/all typechecks. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(sandbox): create src before template sync on CI builds

af3d103

src/ is gitignored; Vercel clones without it so dir-compare failed. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(sandbox): drop redundant syncTemplatesToSrc from setup

63b06b9

Mirror-only setup is enough for CI and fresh clones; use reset/sync when src drifts from templates. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(core): use Korean 화면 속 화면 for picture-in-picture

b8ab3a2

Replace English PiP labels left in the ko locale pack. Co-authored-by: Cursor <cursoragent@cursor.com>

chore(core): remove unused i18n all.ts aggregator

7596e93

Locale pack aggregation lives in html and react; core does not ship this entry. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(sandbox): label Bosnian locale correctly in language picker

23a9323

Intl.DisplayNames maps the v8 `ba` tag to Bashkir; override it to Bosnian. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(packages)!: rename Bosnian locale tag from v8 ba to bs

5fa1016

Video.js v8 used ba for Bosnian, but BCP 47 assigns ba to Bashkir and bs to Bosnian. Use the correct tag so Intl labels and locale lookup work without sandbox overrides. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(core): preserve pt and zh in BuiltInLocale autocomplete

0d601bd

Keep generic language tags in the locale union alongside regional packs. Co-authored-by: Cursor <cursoragent@cursor.com>

refactor(core): centralize locale all.ts with platform re-exports

46b5228

Move the aggregated locale map to @videojs/core/i18n/all and keep thin html/react entry points for existing import paths. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(sandbox): wait for locale registration before rendering i18n UI

06c0f4f

Avoid a flash of English copy when the sandbox locale changes after mount. Co-authored-by: Cursor <cursoragent@cursor.com>

sampotts force-pushed the feat/i18n-ui-elements branch from dd4164e to f70ad12 Compare May 22, 2026 02:13

sampotts force-pushed the feat/i18n-locale-packs branch from 5cacef4 to 06c0f4f Compare May 22, 2026 02:13

vercel Bot deployed to Preview May 22, 2026 02:13 View deployment

cursor Bot reviewed May 22, 2026

View reviewed changes

sampotts closed this May 22, 2026

github-project-automation Bot moved this to Done in Video.js 10 Roadmap May 22, 2026

sampotts deleted the feat/i18n-locale-packs branch May 22, 2026 03:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(packages): add built-in locale packs with v8 parity#1566

feat(packages): add built-in locale packs with v8 parity#1566
sampotts wants to merge 12 commits into
feat/i18n-ui-elementsfrom
feat/i18n-locale-packs

sampotts commented May 19, 2026 •

edited by cursor Bot

Loading

Uh oh!

vercel Bot commented May 19, 2026 •

edited

Loading

Uh oh!

mister-ben May 20, 2026

Uh oh!

mister-ben May 20, 2026

Uh oh!

mister-ben May 20, 2026

Uh oh!

mister-ben May 20, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot May 22, 2026

Uh oh!

sampotts commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		startCasting: 'Übertragung starten',
		stopCasting: 'Übertragung beenden',

		playingLive: 'Zur Live-Übertragung wechseln. Es wird aktuell live abgespielt.',
		seekToLiveEdge: 'Zur Live-Übertragung wechseln. Aktuell wird es nicht live abgespielt.',

Conversation

sampotts commented May 19, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

vercel Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mister-ben May 20, 2026

Choose a reason for hiding this comment

Uh oh!

mister-ben May 20, 2026

Choose a reason for hiding this comment

Uh oh!

mister-ben May 20, 2026

Choose a reason for hiding this comment

Uh oh!

mister-ben May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 22, 2026

Choose a reason for hiding this comment

French locale mixes apostrophe character encodings

Uh oh!

sampotts commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sampotts commented May 19, 2026 •

edited by cursor Bot

Loading

vercel Bot commented May 19, 2026 •

edited

Loading