Fix: transport-only behavior, echo API responses verbatim

Author: vijaykrpp

ip2geo/__init__.py

@@ -1,4 +1,4 @@
 from .client import Ip2Geo
 
 __all__ = ["Ip2Geo"]
-__version__ = "0.1.0"
+__version__ = "0.1.3"

ip2geo/client.py

@@ -16,39 +16,35 @@ def lookup(
     ):
         params = {}
 
-        # API key (optional, API handles missing key response)
         if self.api_key:
             params["key"] = self.api_key
 
-        # format is optional (defaults to JSON if not provided)
         if format:
             params["format"] = format
 
-        # callback only valid for jsonp
         if callback:
             if format != "jsonp":
                 raise ValueError("callback can only be used when format='jsonp'")
             params["callback"] = callback
 
         url = f"{self.BASE_URL}/{ip}" if ip else self.BASE_URL
 
-        response = requests.get(url, params=params, timeout=self.timeout)
-
-        # HTTP-level error (network / server)
-        if not response.ok:
-            raise RuntimeError(
-                f"Ip2Geo API error {response.status_code}: {response.text}"
+        try:
+            response = requests.get(
+                url,
+                params=params,
+                timeout=self.timeout,
             )
-
-        # JSON response handling
-        if format in (None, "json"):
-            data = response.json()
-
-            if not data.get("success", False):
-                # API-level error (eg: missing API key)
-                raise RuntimeError(data.get("error", "Unknown API error"))
-
-            return data
-
-        # Non-JSON formats return raw text
+        except requests.RequestException as e:
+            # TRUE transport failure
+            raise RuntimeError("Unable to reach Ip2Geo API") from e
+
+        # If JSON is expected (default or explicit)
+        if format is None or format == "json":
+            try:
+                return response.json()
+            except ValueError:
+                raise RuntimeError("Expected JSON but received invalid response")
+
+        # XML / YAML / JSONP → raw text
         return response.text

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "ip2geoapi"
-version = "0.1.2"
+version = "0.1.3"
 description = "Official Python SDK for the Ip2Geo API"
 readme = "README.md"
 license = { text = "MIT" }