fix(status): Map USER_CREATOR to a friendly usage error#28
Merged
Conversation
Editing the group/channel creator's admin or banned rights returns the raw RPC error USER_CREATOR, which previously reached the user as the opaque "rpcDoRequest: rpc error code 400: USER_CREATOR". Classify it in the usage family (exit 2) with a clear message, alongside the existing PARTICIPANT_ID_INVALID that already covers a creator target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USER_CREATOR, which previously surfaced to the user as the opaquerpcDoRequest: rpc error code 400: USER_CREATOR.tg.ErrUserCreatorin the usage family (code: usage, exit 2) with the messagethis action isn't allowed on the group/channel creator, alongside the existingPARTICIPANT_ID_INVALIDmapping that already references a creator target.Test plan
go build ./...,go vet,golangci-lint run,go test ./...USER_CREATORadded to the usage-family table test (assertscode=usage, exit 2, friendly non-rpc errormessage).add_adminspromoting the group creator now returns{"error":{"code":"usage","message":"this action isn't allowed on the group/channel creator","rpc_error":"USER_CREATOR"},"exit_code":2}instead of the previous raw
{"code":"unknown","message":"rpcDoRequest: rpc error code 400: USER_CREATOR"}. Therpc_errorenum is preserved for programmatic matching.