Skip to content

Commit ca6321a

Browse files
committed
minor refactor
1 parent 910216f commit ca6321a

1 file changed

Lines changed: 20 additions & 9 deletions

File tree

packages/vike-react/src/integration/onRenderHtml.tsx

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -211,31 +211,42 @@ async function getHtmlInjections(pageContext: PageContextServer) {
211211
return { bodyHtmlBegin, bodyHtmlEnd, headHtmlBegin, headHtmlEnd }
212212
}
213213

214-
type StreamSetting = {
215-
type: 'node' | 'web' | null
216-
enable: boolean | null
217-
require: boolean
218-
}
219214
function getRenderToStreamOptions(
220215
pageContext: PageContextServer,
221216
streamSetting: StreamSetting,
222217
renderToStreamOptions: RenderToStreamOptions | undefined,
223218
): RenderToStreamOptions {
224219
const options: RenderToStreamOptions = {}
225-
// When streamSetting.type is null: let react-streaming decide the stream type
226-
if (streamSetting.type) options.webStream = streamSetting.type === 'web'
220+
221+
if (streamSetting.type) {
222+
options.webStream = streamSetting.type === 'web'
223+
} else {
224+
// Let react-streaming decide the stream type
225+
}
226+
227227
const userAgent =
228228
pageContext.headers?.['user-agent'] ||
229229
// TO-DO/eventually: remove old way of acccessing the User Agent header.
230230
// @ts-ignore
231231
pageContext.userAgent
232232
if (userAgent) options.userAgent = userAgent
233+
233234
// +stream.require is true => default +stream.enable is true
234235
// +stream.require is false => default +stream.enable is false
235-
// Don't override disabling when a bot is detected.
236-
if (streamSetting.enable === false) options.disable = true
236+
if (streamSetting.enable === false) {
237+
options.disable = true
238+
} else {
239+
// Let react-streaming disable streaming when it detects a bot
240+
}
241+
237242
return { ...options, ...renderToStreamOptions }
238243
}
244+
245+
type StreamSetting = {
246+
type: 'node' | 'web' | null
247+
enable: boolean | null
248+
require: boolean
249+
}
239250
function resolveStreamSetting(pageContext: PageContextServer): StreamSetting {
240251
const {
241252
stream,

0 commit comments

Comments
 (0)