Make compatible with AGP 8 - #81
Open
ciriousjoker wants to merge 1 commit into
Open
Conversation
ciriousjoker
commented
Sep 15, 2023
ciriousjoker
commented
Collaborator
- Adds a namespace to make it compatible with Android Gradle Plugin (AGP) 8
- Solution copied from the cloud_firestore package, so it's still backwards compatible with AGP <4.2
ciriousjoker
force-pushed
the
master
branch
from
September 16, 2023 12:52
5662803 to
2d86582
Compare
ciriousjoker
force-pushed
the
master
branch
from
September 16, 2023 17:33
2d86582 to
c8e0c67
Compare
Collaborator
Author
|
@vikram25897 Could you please review this? |
|
Any news on this? The package that depends on cached_video_player is causing trouble at the build, and the whole project's android version became at stale. If there's no update on this soon, I'll have to switch to a different player solution. |
|
Hey I love the work that was done on this package. Would you be merging this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.