Revert "Bump video_player_platform_interface for compatibility with o… - #82
Open
ciriousjoker wants to merge 1 commit into
Open
Revert "Bump video_player_platform_interface for compatibility with o…#82ciriousjoker wants to merge 1 commit into
ciriousjoker wants to merge 1 commit into
Conversation
…ther video_player plugins"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some time ago I reviewed a PR that added this, but this package isn't compatible with
video_player_platform_interface: ^6. I didn't realize this at the time because everything compiled just fine, but I have to revert this for now because it breaks during runtime.@ffactory-ofcl Could you please re-create your PR with the necessary changes to make this compatible?
For anyone reading this who only cares about build and doesn't use the package to actually play back videos (specifically: "don't call init()!"), then a simple dependency override in your pubspec.yaml will do.