Adding transition to null for an overlay that has been rendered and is switching to no longer be rendered

Mark Funk · Mark Funk · commit 59fcc58adec7 · 2014-12-28T09:29:11.000-05:00
diff --git a/src/OverlayMixin.js b/src/OverlayMixin.js
@@ -54,6 +54,9 @@ module.exports = {
     // Save reference to help testing
     if (overlay !== null) {
       this._overlayInstance = React.render(overlay, this._overlayTarget);
+    } else {
+      // Unrender if the component is null for transitions to null
+      this._unrenderOverlay();
     }
   },
 

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,9 @@ module.exports = {`
`54`	`54`	`// Save reference to help testing`
`55`	`55`	`if (overlay !== null) {`
`56`	`56`	`this._overlayInstance = React.render(overlay, this._overlayTarget);`
	`57`	`+ } else {`
	`58`	`+ // Unrender if the component is null for transitions to null`
	`59`	`+ this._unrenderOverlay();`
`57`	`60`	`}`
`58`	`61`	`},`
`59`	`62`