Skip to content

Commit 7dbcd12

Browse files
committed
Merge master
2 parents 1d49a90 + d188343 commit 7dbcd12

33 files changed

Lines changed: 245 additions & 187 deletions

.eslintrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,12 @@
1313
"babel"
1414
],
1515
"rules": {
16-
"brace-style": 0,
1716
"constructor-super": 2,
1817
"comma-dangle": 0,
1918
"comma-spacing": 2,
2019
"comma-style": [2, "last"],
21-
"default-case": 0,
2220
"func-names": 0,
2321
"guard-for-in": 0,
24-
"indent": 0,
2522
"one-var": [2, { "initialized": "never" }],
2623
"padded-blocks": 0,
2724
"prefer-const": 0,

docs/examples/ButtonInput.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ const ButtonInputExample = React.createClass({
1717
let length = this.refs.input.getValue().length;
1818
let style = 'danger';
1919

20-
if (length > 10) { style = 'success'; }
21-
else if (length > 5) { style = 'warning'; }
20+
if (length > 10) style = 'success';
21+
else if (length > 5) style = 'warning';
2222

2323
let disabled = style !== 'success';
2424

docs/examples/Input.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ const ExampleInput = React.createClass({
77

88
validationState() {
99
let length = this.state.value.length;
10-
if (length > 10) { return 'success'; }
11-
else if (length > 5) { return 'warning'; }
12-
else if (length > 0) { return 'error'; }
10+
if (length > 10) return 'success';
11+
else if (length > 5) return 'warning';
12+
else if (length > 0) return 'error';
1313
},
1414

1515
handleChange() {

docs/src/Anchor.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ import React from 'react';
22

33
const Anchor = React.createClass({
44
propTypes: {
5-
id: React.PropTypes.string
5+
id: React.PropTypes.oneOfType([
6+
React.PropTypes.string,
7+
React.PropTypes.number
8+
])
69
},
710
render() {
811
return (

docs/src/PropTable.js

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -146,28 +146,28 @@ const PropTable = React.createClass({
146146
let doclets = prop.doclets || {};
147147

148148
switch (name) {
149-
case 'object':
150-
return name;
151-
case 'union':
152-
return type.value.reduce((current, val, i, list) => {
153-
let item = this.getType({ type: val });
154-
if (React.isValidElement(item)) {
155-
item = React.cloneElement(item, {key: i});
156-
}
157-
current = current.concat(item);
158-
159-
return i === (list.length - 1) ? current : current.concat(' | ');
160-
}, []);
161-
case 'array':
162-
let child = this.getType({ type: type.value });
163-
164-
return <span>{'array<'}{ child }{'>'}</span>;
165-
case 'enum':
166-
return this.renderEnum(type);
167-
case 'custom':
168-
return cleanDocletValue(doclets.type || name);
169-
default:
170-
return name;
149+
case 'object':
150+
return name;
151+
case 'union':
152+
return type.value.reduce((current, val, i, list) => {
153+
let item = this.getType({ type: val });
154+
if (React.isValidElement(item)) {
155+
item = React.cloneElement(item, {key: i});
156+
}
157+
current = current.concat(item);
158+
159+
return i === (list.length - 1) ? current : current.concat(' | ');
160+
}, []);
161+
case 'array':
162+
let child = this.getType({ type: type.value });
163+
164+
return <span>{'array<'}{ child }{'>'}</span>;
165+
case 'enum':
166+
return this.renderEnum(type);
167+
case 'custom':
168+
return cleanDocletValue(doclets.type || name);
169+
default:
170+
return name;
171171
}
172172
},
173173

package.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@
1717
"docs-build": "babel-node tools/build-cli.js --docs-only",
1818
"docs": "babel-node docs/dev-run",
1919
"docs-prod": "npm run docs-build && NODE_ENV=production babel-node docs/server.js",
20-
"docs-prod-unoptimized": "npm run docs-build -- --dev && NODE_ENV=production babel-node docs/server.js"
20+
"docs-prod-unoptimized": "npm run docs-build -- --dev && NODE_ENV=production babel-node docs/server.js",
21+
22+
"minor": "node ./tools/release minor",
23+
"patch": "node ./tools/release patch"
2124
},
2225
"main": "lib/index.js",
2326
"directories": {
@@ -56,10 +59,10 @@
5659
"css-loader": "^0.16.0",
5760
"es5-shim": "^4.1.10",
5861
"eslint": "^1.1.0",
59-
"eslint-config-airbnb": "0.0.7",
62+
"eslint-config-airbnb": "0.0.8",
6063
"eslint-plugin-babel": "^2.0.0",
6164
"eslint-plugin-lodash": "^0.1.3",
62-
"eslint-plugin-mocha": "^0.4.0",
65+
"eslint-plugin-mocha": "^0.5.1",
6366
"eslint-plugin-react": "^3.1.0",
6467
"express": "^4.13.1",
6568
"extract-text-webpack-plugin": "^0.8.2",

src/AffixMixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const AffixMixin = {
3232

3333
checkPosition() {
3434
let DOMNode, scrollHeight, scrollTop, position, offsetTop, offsetBottom,
35-
affix, affixType, affixPositionTop;
35+
affix, affixType, affixPositionTop;
3636

3737
// TODO: or not visible
3838
if (!this.isMounted()) {

src/Carousel.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -249,18 +249,18 @@ const Carousel = React.createClass({
249249
this.state.previousActiveIndex === index && this.props.slide;
250250

251251
return cloneElement(
252-
child,
253-
{
254-
active: isActive,
255-
ref: child.ref,
256-
key: child.key ? child.key : index,
257-
index,
258-
animateOut: isPreviousActive,
259-
animateIn: isActive && this.state.previousActiveIndex != null && this.props.slide,
260-
direction: this.state.direction,
261-
onAnimateOutEnd: isPreviousActive ? this.handleItemAnimateOutEnd : null
262-
}
263-
);
252+
child,
253+
{
254+
active: isActive,
255+
ref: child.ref,
256+
key: child.key ? child.key : index,
257+
index,
258+
animateOut: isPreviousActive,
259+
animateIn: isActive && this.state.previousActiveIndex != null && this.props.slide,
260+
direction: this.state.direction,
261+
onAnimateOutEnd: isPreviousActive ? this.handleItemAnimateOutEnd : null
262+
}
263+
);
264264
},
265265

266266
handleSelect(index, direction) {

src/Dropdown.js

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,21 @@ class Dropdown extends React.Component {
108108
};
109109

110110
switch(event.keyCode) {
111-
case keycode.codes.down:
112-
if (!this.props.open) {
113-
this.toggleOpen();
114-
}
115-
else {
116-
focusNext();
117-
}
118-
event.preventDefault();
119-
break;
120-
case keycode.codes.esc:
121-
case keycode.codes.tab:
122-
if (this.props.open) {
123-
this.handleClose(event);
124-
}
125-
break;
111+
case keycode.codes.down:
112+
if (!this.props.open) {
113+
this.toggleOpen();
114+
} else {
115+
focusNext();
116+
}
117+
event.preventDefault();
118+
break;
119+
case keycode.codes.esc:
120+
case keycode.codes.tab:
121+
if (this.props.open) {
122+
this.handleClose(event);
123+
}
124+
break;
125+
default:
126126
}
127127
}
128128

@@ -136,8 +136,7 @@ class Dropdown extends React.Component {
136136
// to the next focusable input
137137
if (event && event.keyCode === keycode.codes.tab){
138138
setTimeout(this.toggleOpen);
139-
}
140-
else {
139+
} else {
141140
this.toggleOpen();
142141
}
143142

src/DropdownMenu.js

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import keycode from 'keycode';
33
import React from 'react';
44
import ReactDOM from 'react-dom';
55
import RootCloseWrapper from 'react-overlays/lib/RootCloseWrapper';
6-
6+
import ValidComponentChildren from './utils/ValidComponentChildren';
77
import createChainedFunction from './utils/createChainedFunction';
88

99
class DropdownMenu extends React.Component {
@@ -21,18 +21,19 @@ class DropdownMenu extends React.Component {
2121
handleKeyDown(event) {
2222

2323
switch(event.keyCode) {
24-
case keycode.codes.down:
25-
this.focusNext();
26-
event.preventDefault();
27-
break;
28-
case keycode.codes.up:
29-
this.focusPrevious();
30-
event.preventDefault();
31-
break;
32-
case keycode.codes.esc:
33-
case keycode.codes.tab:
34-
this.props.onClose(event);
35-
break;
24+
case keycode.codes.down:
25+
this.focusNext();
26+
event.preventDefault();
27+
break;
28+
case keycode.codes.up:
29+
this.focusPrevious();
30+
event.preventDefault();
31+
break;
32+
case keycode.codes.esc:
33+
case keycode.codes.tab:
34+
this.props.onClose(event);
35+
break;
36+
default:
3637
}
3738
}
3839

@@ -77,7 +78,7 @@ class DropdownMenu extends React.Component {
7778
}
7879

7980
render() {
80-
const items = React.Children.map(this.props.children, child => {
81+
const items = ValidComponentChildren.map(this.props.children, child => {
8182
let {
8283
children,
8384
onKeyDown,

0 commit comments

Comments
 (0)