Commit 87ef3a2
committed
Suggest wrapping Collapse child in no-margin node
It makes a big difference when you have elements with margin or padding;
the animation appears much smoother when the contents are enclosed
in a node with zero padding and zero margin (like a raw `<div>`).
Here are two examples.
* with a div: https://cloud.githubusercontent.com/assets/4317806/10871987/4bf4ea48-80ac-11e5-84f5-45c955a22f47.gif
* without a div: https://cloud.githubusercontent.com/assets/4317806/10871988/504aee62-80ac-11e5-9232-7dc97c151fef.gif
(source: wchargin/lc3@344da3a)
The example already wraps its contents in a `<div>`,
but it's not clear that or why this is beneficial.1 parent 3bb42f2 commit 87ef3a2
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
952 | 952 | | |
953 | 953 | | |
954 | 954 | | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
955 | 969 | | |
956 | 970 | | |
957 | 971 | | |
| |||
0 commit comments