Skip to content

Commit a1494c8

Browse files
committed
Merge pull request react-bootstrap#1349 from AlexKVal/liftup
v0.26-rc liftup
2 parents 17cab50 + 70dbc55 commit a1494c8

92 files changed

Lines changed: 881 additions & 752 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@
1616
"constructor-super": 2,
1717
"comma-dangle": 0,
1818
"eqeqeq": [2, "allow-null"],
19-
"func-names": 0,
20-
"guard-for-in": 0,
2119
"one-var": [2, { "initialized": "never" }],
2220
"prefer-const": 0,
2321
"key-spacing": 0,
2422
"no-eq-null": 0,
25-
"no-else-return": 0,
2623
"no-param-reassign": 0,
2724
"no-this-before-super": 2,
2825
"no-undef": 2,

docs/examples/ImageResponsive.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
const imageResponsiveInstance = (
2+
<Image src="/assets/thumbnail.png" responsive />
3+
);
4+
5+
React.render(imageResponsiveInstance, mountNode);

docs/examples/ImageShape.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
const imageShapeInstance = (
2+
<Grid>
3+
<Row>
4+
<Col xs={6} md={4}>
5+
<Image src="/assets/thumbnail.png" rounded />
6+
</Col>
7+
<Col xs={6} md={4}>
8+
<Image src="/assets/thumbnail.png" circle />
9+
</Col>
10+
<Col xs={6} md={4}>
11+
<Image src="/assets/thumbnail.png" thumbnail />
12+
</Col>
13+
</Row>
14+
</Grid>
15+
);
16+
17+
React.render(imageShapeInstance, mountNode);

docs/server.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ if (development) {
2121
let webpackPort = process.env.WEBPACK_DEV_PORT;
2222
let target = `http://${ip.address()}:${webpackPort}`;
2323

24-
app.get('/assets/*', function(req, res) {
24+
app.get('/assets/*', (req, res) => {
2525
proxy.web(req, res, { target });
2626
});
2727

28-
proxy.on('error', function(e) {
28+
proxy.on('error', e => {
2929
console.log('Could not connect to webpack proxy'.red);
3030
console.log(e.toString().red);
3131
});
@@ -49,7 +49,7 @@ if (development) {
4949
app.use(express.static(path.join(__dirname, '../docs-built')));
5050
}
5151

52-
app.listen(port, function() {
52+
app.listen(port, () => {
5353
console.log(`Server started at:`);
5454
console.log(`- http://localhost:${port}`);
5555
console.log(`- http://${ip.address()}:${port}`);

docs/src/ComponentsPage.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,22 @@ const ComponentsPage = React.createClass({
675675
<PropTable component="Col"/>
676676
</div>
677677

678+
{/* Images */}
679+
<div className="bs-docs-section">
680+
<h1 className="page-header"><Anchor id="images">Images</Anchor></h1>
681+
682+
<h3><Anchor id="image-shape">Shape</Anchor></h3>
683+
<p>Use the <code>rounded</code>, <code>circle</code> and <code>thumbnail</code> props to customise the image.</p>
684+
<ReactPlayground codeText={Samples.ImageShape} />
685+
686+
<h3><Anchor id="image-responsive">Responsive</Anchor></h3>
687+
<p>Use the <code>responsive</code> to scale image nicely to the parent element.</p>
688+
<ReactPlayground codeText={Samples.ImageResponsive} />
689+
690+
<h3><Anchor id="image-props">Props</Anchor></h3>
691+
<PropTable component="Image"/>
692+
</div>
693+
678694
{/* Thumbnail */}
679695
<div className="bs-docs-section">
680696
<h1 className="page-header"><Anchor id="thumbnail">Thumbnail</Anchor></h1>
@@ -937,6 +953,7 @@ const ComponentsPage = React.createClass({
937953
<NavItem href="#alerts" key={14}>Alerts</NavItem>
938954
<NavItem href="#carousels" key={15}>Carousels</NavItem>
939955
<NavItem href="#grids" key={16}>Grids</NavItem>
956+
<NavItem href="#images" key={29}>Images</NavItem>
940957
<NavItem href="#thumbnail" key={17}>Thumbnail</NavItem>
941958
<NavItem href="#listgroup" key={18}>List group</NavItem>
942959
<NavItem href="#labels" key={19}>Labels</NavItem>

docs/src/GettingStartedPage.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ $ bower install react-bootstrap`
104104
<div className="bs-docs-section">
105105
<h2 className="page-header"><Anchor id="browser-support">Browser support</Anchor></h2>
106106
<p>We aim to support all browsers supported by both <a href="http://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills">React</a> and <a href="http://getbootstrap.com/getting-started/#support">Bootstrap</a>.</p>
107+
<p>Unfortunately, due to the lack of resources and the will of dedicating the efforts to modern browsers and getting closer to Bootstrap's features, we will not be testing <code>react-bootstrap</code> against IE8 anymore.
108+
<br/>We will however continue supporting IE8 as long as people submit PRs addressing compatibility issues with it.</p>
107109

108110
<p>React requires <a href="http://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills">polyfills for non-ES5 capable browsers.</a></p>
109111

110-
<p><a href="http://jquery.com">jQuery</a> is currently required only for IE8 support for components which require reading element positions from the DOM: <code>Popover</code> and <code>Tooltip</code> when launched with <code>OverlayTrigger</code>. We would like to remove this dependency in future versions but for now, including the following snippet in your page should have you covered:</p>
111-
112112
<div className="highlight">
113113
<CodeExample
114114
mode="htmlmixed"
@@ -123,7 +123,6 @@ $ bower install react-bootstrap`
123123
</script>
124124
<script src="//cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.2/html5shiv.min.js"></script>
125125
<script src="//cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.2/html5shiv-printshiv.min.js"></script>
126-
<script src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
127126
<script src="//cdnjs.cloudflare.com/ajax/libs/es5-shim/3.4.0/es5-shim.js"></script>
128127
<script src="//cdnjs.cloudflare.com/ajax/libs/es5-shim/3.4.0/es5-sham.js"></script>
129128
<![endif]-->`

docs/src/PropTable.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import merge from 'lodash/object/merge';
1+
import merge from 'lodash-compat/object/merge';
22
import React from 'react';
33
import Glyphicon from '../../src/Glyphicon';
44
import Label from '../../src/Label';
@@ -174,9 +174,9 @@ const PropTable = React.createClass({
174174
return 'function';
175175
} else if (typeName === 'bool') {
176176
return 'boolean';
177-
} else {
178-
return typeName;
179177
}
178+
179+
return typeName;
180180
},
181181

182182
renderEnum(enumType) {

docs/src/ReactPlayground.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,15 @@ const CarouselItem = require('../../src/CarouselItem');
1717
const Col = require('../../src/Col');
1818
const Collapse = require('../../src/Collapse');
1919
const CollapsibleNav = require('../../src/CollapsibleNav');
20-
const Dropdown = require('../../src/Dropdown').default;
20+
const Dropdown = require('../../src/Dropdown');
2121
const DropdownButton = require('../../src/DropdownButton');
2222
const DropdownMenu = require('../../src/DropdownMenu');
2323
const Fade = require('../../src/Fade');
2424
const FormControls = require('../../src/FormControls');
2525
const Glyphicon = require('../../src/Glyphicon');
2626
const Grid = require('../../src/Grid');
2727
const Input = require('../../src/Input');
28+
const Image = require('../../src/Image');
2829
const Jumbotron = require('../../src/Jumbotron');
2930
const Label = require('../../src/Label');
3031
const ListGroup = require('../../src/ListGroup');

docs/src/Samples.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ export default {
105105
InputHorizontal: require('fs').readFileSync(__dirname + '/../examples/InputHorizontal.js', 'utf8'),
106106
InputWrapper: require('fs').readFileSync(__dirname + '/../examples/InputWrapper.js', 'utf8'),
107107
MenuItem: require('fs').readFileSync(__dirname + '/../examples/MenuItem.js', 'utf8'),
108+
ImageResponsive: require('fs').readFileSync(__dirname + '/../examples/ImageResponsive.js', 'utf8'),
109+
ImageShape: require('fs').readFileSync(__dirname + '/../examples/ImageShape.js', 'utf8'),
108110

109111
Overlay: require('fs').readFileSync(__dirname + '/../examples/Overlay.js', 'utf8'),
110112
OverlayCustom: require('fs').readFileSync(__dirname + '/../examples/OverlayCustom.js', 'utf8')

karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint no-var: 0, babel/object-shorthand: 0, vars-on-top: 0 */
1+
/* eslint no-var: 0, babel/object-shorthand: 0, vars-on-top: 0, func-names: 0 */
22
require('babel/register');
33

44
var webpackConfig = require('./webpack/test.config.js');

0 commit comments

Comments
 (0)