Skip to content

chore: run tests using modern python#359

Merged
vil02 merged 5 commits into
vil02:masterfrom
cclauss:patch-1
Oct 9, 2025
Merged

chore: run tests using modern python#359
vil02 merged 5 commits into
vil02:masterfrom
cclauss:patch-1

Conversation

@cclauss

@cclauss cclauss commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

@cclauss cclauss changed the title Test Python 3.14 before it is released next week. Test Python 3.14 before it is released next week Oct 1, 2025
@codecov

codecov Bot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9358a94) to head (c023b2c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          309       309           
  Branches        26        26           
=========================================
  Hits           309       309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss

cclauss commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Py3.14 is blocked by:

Reverting to Py3.13 for now.

Updated Python version in workflow from 3.14 to 3.13.
@cclauss

cclauss commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

The Required Py3.11 test needs to be un-required because we now run Py3.12 instead of Py3.11.

@vil02

vil02 commented Oct 3, 2025

Copy link
Copy Markdown
Owner

@cclauss: since puzzle_generator is not (yet!) a super crucial python package and therefore it does not really require tests across all python versions, I will wait for the release of python 3.14.

If you do not mind, I will update your branch accordingly and then merge it.

Thanks again for creating this PR. I wrote you a message on discord.

@cclauss cclauss changed the title Test Python 3.14 before it is released next week Test Python 3.14 Oct 7, 2025
@cclauss

cclauss commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

I will wait for the release of Python 3.14.

https://www.python.org/downloads/release/python-3140/

@vil02 vil02 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss: I will push my suggestions into your branch.

Comment thread .github/workflows/python_test.yml Outdated
Comment thread .github/workflows/python_test.yml Outdated
Comment thread .github/workflows/python_test.yml Outdated
Comment thread .github/workflows/python_test.yml Outdated
Comment thread .github/workflows/python_test.yml Outdated
@vil02 vil02 changed the title Test Python 3.14 chore: run tests using modern python Oct 9, 2025

@vil02 vil02 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cclauss for bringing my attention into this.

python versions, C++ standards etc. - time runs fast.

@vil02 vil02 merged commit 97e6d27 into vil02:master Oct 9, 2025
14 checks passed
@cclauss cclauss deleted the patch-1 branch October 9, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants