Skip to content

fix zlib error of 'Error: unexpected end of file'#225

Open
JanzenZhangChen wants to merge 2 commits into
villadora:masterfrom
JanzenZhangChen:dev
Open

fix zlib error of 'Error: unexpected end of file'#225
JanzenZhangChen wants to merge 2 commits into
villadora:masterfrom
JanzenZhangChen:dev

Conversation

@JanzenZhangChen
Copy link
Copy Markdown

fix zlib error of 'Error: unexpected end of file'.

@JanzenZhangChen
Copy link
Copy Markdown
Author

now I have no idea how to fix this problem, couldnt pass the "on the nose" mocha test.

@monkpow
Copy link
Copy Markdown
Collaborator

monkpow commented May 10, 2017

Hey @JanzenZhangChen, thanks for the patch.

Quick glance at the tests shows:

  1) test userResDecorator on html response from github is able to read and manipulate the response:
     Error: incorrect header check
      at Zlib._handle.onerror (zlib.js:366:17)

Seems likely related to your patch. I'd like that to pass, and to have a test for this change to accept.

Let me know any questions, thanks!

@scr4bble
Copy link
Copy Markdown

scr4bble commented Apr 12, 2018

Is this trying to fix the issue #177 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants