fix the negation evaluations in fake sql#59
Merged
Conversation
dec4143 to
465f970
Compare
aaronm67
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Negate both results from the binary operation evaluation to ensure negation is correctly applied.
How negation works
If a 1 needs to be negated, 1 ^ 1 = 0
If a 0 needs to be negated, 0 ^ 1 = 1
If 1 doesn’t need to be negated, 1 ^ 0 = 1
If 0 doesn’t need to be negated, 0 ^ 0 = 0
NOTE:
There is some parsing issue where when a single NOT statement is applied directly after WHERE clause, the
negatedproperty is not set correctly. Took a look but couldn't fix it in a short time so gonna leave it for now. We don't write NOT for a single statement anyways since we use!=orNOT INdirectly.Example
Prior to the change, the following query will return the count 9, because
NOT (powerups > :powerups)is always true, and the result doesn't filter out the characterluigi, who hasnesconsole and5powerups.After the change, the count result is 8.
Tests
Added unit tests