Fix: char-code for *whitespaces* characters#123
Draft
kilianmh wants to merge 1 commit into
Draft
Conversation
Use `char-code` for `*whitespaces*` characters. This should prevent future problems with some implementations that do not support specific characters in the reader.
kilianmh
force-pushed
the
fix/whitespace-char-codes
branch
from
368861d to
14ed12f
Compare
Owner
|
oooh this looks wise, but we are loosing a user-facing QoL. We can easily see what's in the whitespaces variable: str:*whitespaces*
(#\Backspace #\Tab #\Newline #\Newline #\Vt #\Page #\Return #\ #\Rubout
#\Next-Line #\NO-BREAK_SPACE)not so with charcodes. I really like cl-str to be easily inspectable, clear, etc. Maybe there's a better way. Or we maintainers have to work harder and add some tests / a CI for the future. |
Collaborator
Author
Is it? I get the same result with this PR when putting Also there are comments after every character-code with the respective character. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
char-codefor*whitespaces*characters.This should prevent future problems with some
implementations that do not support specific
characters in the reader.
This should work regardless of implementation.
Tested on: sbcl, ccl, ecl, abcl, cmu, allegro.
From now on we should add characters
only with char-code to avoid errors? @vindarel