Skip to content

Commit 3b73da8

Browse files
author
Vineeth Wilson
committed
fix(ci): address CodeRabbit review comments on qdrant health-check
- Pin qdrant image from 'latest' to 'v1.17.0' for reproducibility - Upgrade health-check from bare TCP to HTTP /healthz probe via bash TCP so the job waits for Qdrant to be fully serving, not just port-open - Replace deprecated codecov/test-results-action@v1 with codecov/codecov-action@v5 using report_type: test_results - Guard integration test step: skip gracefully when no test_*.py files exist yet (avoids pytest exit code 4 on empty directory)
1 parent 3893521 commit 3b73da8

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,11 @@ jobs:
7777

7878
- name: Upload test results to Codecov
7979
if: ${{ !cancelled() && matrix.python-version == '3.11' }}
80-
uses: codecov/test-results-action@v1
80+
uses: codecov/codecov-action@v5
8181
with:
8282
token: ${{ secrets.CODECOV_TOKEN }}
83+
files: ./junit.xml
84+
report_type: test_results
8385

8486
# ──────────────────────────────────────────────────────────────────────────
8587
# Integration tests (spins up Neo4j + Qdrant in Docker)
@@ -103,11 +105,11 @@ jobs:
103105
--health-retries 10
104106
105107
qdrant:
106-
image: qdrant/qdrant:latest
108+
image: qdrant/qdrant:v1.17.0
107109
ports:
108110
- 6333:6333
109111
options: >-
110-
--health-cmd "bash -c ':> /dev/tcp/localhost/6333'"
112+
--health-cmd "bash -ec 'exec 3<>/dev/tcp/127.0.0.1/6333 && printf \"GET /healthz HTTP/1.1\\r\\nHost: 127.0.0.1\\r\\nConnection: close\\r\\n\\r\\n\" >&3 && read -r status <&3 && [[ $status == *\" 200 \"* ]]'"
111113
--health-interval 10s
112114
--health-timeout 5s
113115
--health-retries 10
@@ -132,4 +134,9 @@ jobs:
132134
NEO4J_PASSWORD: codemind123
133135
QDRANT_HOST: localhost
134136
QDRANT_PORT: 6333
135-
run: pytest tests/integration/ -m integration -v
137+
run: |
138+
if find tests/integration -name 'test_*.py' 2>/dev/null | grep -q .; then
139+
python -m pytest tests/integration/ -m integration -v
140+
else
141+
echo "No integration tests found — skipping."
142+
fi

0 commit comments

Comments
 (0)