Fix clippy errors

Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>

Author: tylerfanelli

src/error.rs

@@ -615,7 +615,7 @@ impl std::convert::From<std::io::Error> for UserApiError {
 
 impl From<UserApiError> for io::Error {
     fn from(value: UserApiError) -> Self {
-        io::Error::new(io::ErrorKind::Other, value)
+        io::Error::other(value)
     }
 }
 
@@ -742,7 +742,7 @@ impl std::fmt::Display for AttestationReportError {
 
 impl From<AttestationReportError> for std::io::Error {
     fn from(value: AttestationReportError) -> Self {
-        std::io::Error::new(std::io::ErrorKind::Other, value)
+        std::io::Error::other(value)
     }
 }
 

src/firmware/host/types/snp.rs

@@ -48,11 +48,12 @@ impl BitOrAssign for SnpPlatformStatusFlags {
 }
 
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 #[repr(C)]
 /// Certificates which are accepted for [CertTableEntry](self::CertTableEntry)
 pub enum CertType {
     /// Empty or closing entry for the CertTable
+    #[default]
     Empty,
 
     /// AMD Root Signing Key (ARK) certificate
@@ -74,12 +75,6 @@ pub enum CertType {
     OTHER(uuid::Uuid),
 }
 
-impl Default for CertType {
-    fn default() -> Self {
-        Self::Empty
-    }
-}
-
 impl Display for CertType {
     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
         let guid = match self {
@@ -273,7 +268,7 @@ impl Ord for CertTableEntry {
 
 impl PartialOrd for CertTableEntry {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        Some(self.cert_type.cmp(&other.cert_type))
+        Some(self.cmp(other))
     }
 }