feat(dsp): VIS-59 use sample bundle tagging config on startup#5
Open
cassandrabailey293 wants to merge 1 commit into
Open
feat(dsp): VIS-59 use sample bundle tagging config on startup#5cassandrabailey293 wants to merge 1 commit into
cassandrabailey293 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates DSP Standalone startup to automatically source and stage a tagging PDP workflow YAML (preferably from an unpacked Virtru bundle) and wires the staged file into the running DSP container via Docker Compose.
Changes:
- Add startup logic in
setup_and_validate.shto locatetagging-pdp-workflows.yaml, optionally prompt the user, and stage it under.generated/. - Update
dsp.yamlto point the tagging PDP service at/config/tagging-pdp-workflows.yaml. - Bind-mount the staged workflow file into the DSP container and ignore
.generated/in git.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup_and_validate.sh | Adds workflow resolution + staging before bringing up the compose stack. |
| dsp.yaml | Changes tagging PDP config path to the mounted /config/tagging-pdp-workflows.yaml. |
| docker-compose.yaml | Mounts the staged workflow YAML into the DSP container. |
| .gitignore | Ignores the generated staging directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+269
to
+271
| mkdir -p "$GENERATED_DIR" | ||
| if grep -q '^taggingpdpWorkflows:$' "$source_path" && grep -q '^ config\.yaml:$' "$source_path"; then | ||
| awk ' |
| ' "$source_path" > "$GENERATED_TAGGING_PDP_WORKFLOW" | ||
| log_info "Extracted inner tagging PDP workflow from bundle wrapper format" | ||
| else | ||
| cp "$source_path" "$GENERATED_TAGGING_PDP_WORKFLOW" |
| restart: always | ||
| volumes: | ||
| - ./dsp-keys:/dsp-keys:z | ||
| - ./.generated/tagging-pdp-workflows.yaml:/config/tagging-pdp-workflows.yaml:ro,z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds tagging config to dsp-standalone.
the setup-and-validate script expects a path to your dsp bundle. the sample tagging workflow will be extracted from the bundle by default. if none is present, it will prompt you for the path to your tagging workflow.