Merge pull request #1566 from virtualcell/vcell-help-hyperlinks

Ezequiel-Valencia · web-flow · commit 1ea2c1878982 · 2025-08-12T13:58:18.000-04:00
External Links are placed in Paranthesiss
diff --git a/vcell-client/src/main/java/org/vcell/documentation/JavaHelpHtmlWriter.java b/vcell-client/src/main/java/org/vcell/documentation/JavaHelpHtmlWriter.java
@@ -126,7 +126,8 @@ private void printComponent(Documentation documentation, DocTextComponent docCom
                 }catch(Exception e1){
                     System.err.println("Error in xml file:" + sourceHtmlFile.getAbsolutePath().replace(".html", ".xml") + ". Server failed to respond: " + docLink.getTarget()+". It might be a bad URL.");
                 }
-                pw.print("<a href=\""+docLink.getTarget()+"\">");
+                pw.print(docLink.getText());
+                pw.print(" (<i>" + docLink.getTarget() + " </i>)");
             }
             else
             {
@@ -150,9 +151,9 @@ private void printComponent(Documentation documentation, DocTextComponent docCom
                     String relativePathToTarget = getHelpRelativePath(directory, htmlFile);
                     pw.print("<a href=\""+relativePathToTarget+"\">");
                 }
+                pw.print(docLink.getText());
+                pw.print("</a>");
             }
-            pw.print(docLink.getText());
-            pw.print("</a>");
         }else if (docComp instanceof DocImageReference imageReference){
             DocumentImage targetImage = documentation.getDocumentImage(imageReference);
             if (targetImage==null){

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,8 @@ private void printComponent(Documentation documentation, DocTextComponent docCom`
`126`	`126`	`}catch(Exception e1){`
`127`	`127`	`System.err.println("Error in xml file:" + sourceHtmlFile.getAbsolutePath().replace(".html", ".xml") + ". Server failed to respond: " + docLink.getTarget()+". It might be a bad URL.");`
`128`	`128`	`}`
`129`		`- pw.print("<a href=\""+docLink.getTarget()+"\">");`
	`129`	`+ pw.print(docLink.getText());`
	`130`	`+ pw.print(" (<i>" + docLink.getTarget() + " </i>)");`
`130`	`131`	`}`
`131`	`132`	`else`
`132`	`133`	`{`
`@@ -150,9 +151,9 @@ private void printComponent(Documentation documentation, DocTextComponent docCom`
`150`	`151`	`String relativePathToTarget = getHelpRelativePath(directory, htmlFile);`
`151`	`152`	`pw.print("<a href=\""+relativePathToTarget+"\">");`
`152`	`153`	`}`
	`154`	`+ pw.print(docLink.getText());`
	`155`	`+ pw.print("</a>");`
`153`	`156`	`}`
`154`		`- pw.print(docLink.getText());`
`155`		`- pw.print("</a>");`
`156`	`157`	`}else if (docComp instanceof DocImageReference imageReference){`
`157`	`158`	`DocumentImage targetImage = documentation.getDocumentImage(imageReference);`
`158`	`159`	`if (targetImage==null){`