Validate sbmlName against invalid XML chars on every setter

Add SpeciesContext.fixAndValidateSbmlName as the single chokepoint for
all 9 setSbmlName methods (SpeciesContext, Structure, ReactionStep,
BioModel, Model.GlobalParameter, AssignmentRule, RateRule, BioEvent,
plus existing fixSbmlName fix-only path). The helper rejects C0 control
chars and U+FFFD via XmlChars.requireValidAttributeContent, throwing
PropertyVetoException so existing UI catch blocks render a friendly
error instead of a stack trace.

This closes the SBML import → setSbmlName → cached VCML attribute path
that produced the un-parseable cached XML observed in BioModels
311226221 and 311875206.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: jcschaff

vcell-core/src/main/java/cbit/vcell/biomodel/BioModel.java

@@ -1014,7 +1014,7 @@ public void setName(java.lang.String name) throws java.beans.PropertyVetoExcepti
 
     public void setSbmlName(String newString) throws PropertyVetoException{
         String oldValue = this.sbmlName;
-        String newValue = SpeciesContext.fixSbmlName(newString);
+        String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
 
         fireVetoableChange("sbmlName", oldValue, newValue);
         this.sbmlName = newValue;

vcell-core/src/main/java/cbit/vcell/mapping/AssignmentRule.java

@@ -99,8 +99,8 @@ public void setName(String name) {
 	}
 	public void setSbmlName(String newString) throws PropertyVetoException {
 		String oldValue = this.sbmlName;
-		String newValue = SpeciesContext.fixSbmlName(newString);
-		
+		String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
+
 		fireVetoableChange("sbmlName", oldValue, newValue);
 		this.sbmlName = newValue;
 		firePropertyChange("sbmlName", oldValue, newValue);

vcell-core/src/main/java/cbit/vcell/mapping/BioEvent.java

@@ -384,8 +384,8 @@ public void setName(String newValue) throws PropertyVetoException {
 	}
 	public void setSbmlName(String newString) throws PropertyVetoException {
 		String oldValue = this.sbmlName;
-		String newValue = SpeciesContext.fixSbmlName(newString);
-		
+		String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
+
 		fireVetoableChange("sbmlName", oldValue, newValue);
 		this.sbmlName = newValue;
 		firePropertyChange("sbmlName", oldValue, newValue);

vcell-core/src/main/java/cbit/vcell/mapping/RateRule.java

@@ -112,8 +112,8 @@ public void setName(String name) {
 	}
 	public void setSbmlName(String newString) throws PropertyVetoException {
 		String oldValue = this.sbmlName;
-		String newValue = SpeciesContext.fixSbmlName(newString);
-		
+		String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
+
 		fireVetoableChange("sbmlName", oldValue, newValue);
 		this.sbmlName = newValue;
 		firePropertyChange("sbmlName", oldValue, newValue);

vcell-core/src/main/java/cbit/vcell/model/Model.java

@@ -1035,7 +1035,7 @@ public void setSbmlId(String newValue) throws PropertyVetoException{
 
         public void setSbmlName(String newString) throws PropertyVetoException{
             String oldValue = this.sbmlName;
-            String newValue = SpeciesContext.fixSbmlName(newString);
+            String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
 
             fireVetoableChange("sbmlName", oldValue, newValue);
             this.sbmlName = newValue;

vcell-core/src/main/java/cbit/vcell/model/SpeciesContext.java

@@ -10,6 +10,8 @@
 
 package cbit.vcell.model;
 
+import org.vcell.util.xml.XmlChars;
+
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
 import java.beans.PropertyVetoException;
@@ -299,10 +301,23 @@ public static String fixSbmlName(String newString) {
 	String newValue = sb.toString();
 	return newValue;
 }
+
+public static String fixAndValidateSbmlName(String newString, Object source) throws PropertyVetoException {
+	String newValue = fixSbmlName(newString);
+	if (newValue == null) return null;
+	try {
+		XmlChars.requireValidAttributeContent(newValue, "sbmlName");
+	} catch (IllegalArgumentException ex) {
+		throw new PropertyVetoException(ex.getMessage(),
+				new PropertyChangeEvent(source, "sbmlName", null, newValue));
+	}
+	return newValue;
+}
+
 public void setSbmlName(String newString) throws PropertyVetoException {
 	String oldValue = this.sbmlName;
-	String newValue = fixSbmlName(newString);
-	
+	String newValue = fixAndValidateSbmlName(newString, this);
+
 	fireVetoableChange("sbmlName", oldValue, newValue);
 	this.sbmlName = newValue;
 	firePropertyChange("sbmlName", oldValue, newValue);

vcell-core/src/main/java/cbit/vcell/model/Structure.java

@@ -68,8 +68,8 @@ public String getSbmlName() {
 	}
 	public void setSbmlName(String newString) throws PropertyVetoException {
 		String oldValue = this.sbmlName;
-		String newValue = SpeciesContext.fixSbmlName(newString);
-		
+		String newValue = SpeciesContext.fixAndValidateSbmlName(newString, this);
+
 		fireVetoableChange("sbmlName", oldValue, newValue);
 		this.sbmlName = newValue;
 		firePropertyChange("sbmlName", oldValue, newValue);