VCell Connection Failure Fix#1471
Merged
Ezequiel-Valencia merged 8 commits intomasterfrom Apr 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- vcell-rest/src/main/resources/application.properties: Language not supported
Comments suppressed due to low confidence (1)
vcell-restclient/src/main/java/org/vcell/restclient/auth/InteractiveLogin.java:288
- When using audience.getPort() for localhost, consider that if no explicit port is set, getPort() may return -1, resulting in an invalid URL portion. Validate the port value or use a default port if needed.
String audiencePort = audience.getHost().equals("localhost") ? ":" + audience.getPort() : "";
jcschaff
approved these changes
Apr 7, 2025
Member
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
discussed with Ezequiel, looks good, he explained the changes. Approved.
Simplify the configuration process by only having the remote API audience be the changing variable for each environment. Also ask for refresh tokens from Auth0 by specifying the audience and that we want offline access.
No longer have individual files to execute different NPM commands, but instead provide the NPM command through a dynamic environment variable.
Contributor
Author
|
Modified the Java client, Angular app, and Auth0 config. |
Member
|
@AvocadoMoon stepped me though the recent Angular security changes - looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After extended period of time VCell would be unable to create a new connection to the servers, and perform functions.
Solution
Fix the refresh system within the Java client and Auth0, such that now refresh tokens function appropriately.